Skip to content

Commit 4b4c5a5

Browse files
committed
close #158 auth printing my password and username after submitting it in git bash
1 parent b770afe commit 4b4c5a5

File tree

3 files changed

+15
-17
lines changed

3 files changed

+15
-17
lines changed

ci/CHANGELOG.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
This new version contains a **Major** semantic change in the **wrapup** command. It has been returned to the default behaviour, so wrapup no longer requires `--hard` to add you changes, it does that automatically. I apologize for the inconvenience and confusion these changes to `wrapup` have introduced.
2-
The output and error handling is under improvement to make the tool more userfriendly to use.
3-
1+
##Changelog
2+
The new release of git-phlow adds support for windows in _beta_. Overall improvements have been made to increase stability and remove
3+
various bugs and odd behaviours.
44

5+
#### Features
6+
- Windows is now support in a pre-release version
7+
- Add Less and More browsing #150 @groenborg
8+
- Add no-color option for windows #148 @kryptag
59

610
#### Improvements
7-
- upnext now has a prefix option #79 @groenborg
8-
- deliver now always change back to your default branch #75 @groenborg
9-
- made workon less verbose #115 @groenborg
10-
- return wrapup to old behaviour #89 @groenborg
11-
- wrapup now has a `--force` flag for a custom commit message #90 @groenborg
11+
- Use Scanner in stead of buffered Reader #149 @groenborg
12+
- Add windows binary to GitHub release #151 @groenborg
13+
- Added windows worker to concourse ci #144
1214

1315
#### Bug fixes
14-
- private repo access for web api should be fixed #81 #83 #84@groenborg
15-
- fixed typo in workon #95 @randomsort
16-
- removed squash message #85 @groenborg
17-
18-
16+
- Colors are buggy when terminal width is changed #131 @groenborg
17+
- username and password are no longer printed #158 @groenborg
18+
- version was stuck at 1.0.0 #167 @groenborg

ci/pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
- get: tollgate
77
trigger: true
88
- get: gp-version
9-
params: {bump: patch}
9+
params: {bump: minor}
1010
- put: gp-version
1111
params: {file: gp-version/version}
1212
- task: integration

phlow/auth.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ func Auth() {
4545
//Read user input password
4646
password := ReadPassword("password: ")
4747

48-
fmt.Println(username)
49-
fmt.Println(password)
5048
token, err := plugins.GitHub.Auth(username, password)
5149
if err != nil {
5250
fmt.Println()
@@ -58,7 +56,7 @@ func Auth() {
5856
githandler.ConfigSet("user", username, "phlow")
5957

6058
fmt.Println("")
61-
fmt.Println("Successfully authorized: 'git phlow' is now enabled")
59+
fmt.Println(fmt.Sprintf("%s Successfully authorized: 'git phlow' is now enabled", username))
6260
}
6361

6462
//ReadInput ...

0 commit comments

Comments
 (0)