[SSD-147] refactor: 요청 DTO validation 및 응답 공통화 (#86)

devyejin · web-flow · commit ebdf344eb424 · 2025-03-05T22:52:32.000+09:00
diff --git a/backend/src/main/java/com/timepaper/backend/domain/postit/dto/PostitCreateRequestDto.java b/backend/src/main/java/com/timepaper/backend/domain/postit/dto/PostitCreateRequestDto.java
@@ -13,11 +13,11 @@
 public class PostitCreateRequestDto {
 
   @NotEmpty
-  @Length(max = 20)
+  @Length(max = 20, message = "작성자 이름은 최대 20자까지 입력할 수 있습니다.")
   private String authorName;
 
   @NotEmpty
-  @Length(max = 155)
+  @Length(max = 155, message = "내용은 최대 155자까지 입력할 수 있습니다.")
   private String content;
 
   private String imageUrl;
diff --git a/backend/src/main/java/com/timepaper/backend/domain/timepaper/controller/TimePaperController.java b/backend/src/main/java/com/timepaper/backend/domain/timepaper/controller/TimePaperController.java
@@ -7,6 +7,7 @@
 import com.timepaper.backend.domain.timepaper.service.TimePaperService;
 import com.timepaper.backend.domain.user.entity.User;
 import com.timepaper.backend.global.dto.ApiResponse;
+import jakarta.validation.Valid;
 import java.util.UUID;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
@@ -33,7 +34,7 @@ public class TimePaperController {
 
   @PostMapping
   public ResponseEntity<ApiResponse<TimePaperResponseDto>> createTimePaper(
-      @RequestBody TimePaperCreateRequestDto timePaperCreateRequestDto,
+      @Valid @RequestBody TimePaperCreateRequestDto timePaperCreateRequestDto,
       Authentication authentication) {
 
     TimePaperResponseDto responseDto =
@@ -72,7 +73,7 @@ public ResponseEntity<ApiResponse<Void>> deleteTimePaper(@PathVariable UUID time
   @PatchMapping("/{timePaperId}/lock")
   public ResponseEntity<ApiResponse<TimePaperLockResponseDto>> lockTimePaper(
       @PathVariable UUID timePaperId,
-      @RequestBody TimePaperLockRequestDto timePaperLockRequestDto,
+      @RequestBody @Valid TimePaperLockRequestDto timePaperLockRequestDto,
       @AuthenticationPrincipal User requester
   ) {
 
diff --git a/backend/src/main/java/com/timepaper/backend/domain/timepaper/dto/request/TimePaperLockRequestDto.java b/backend/src/main/java/com/timepaper/backend/domain/timepaper/dto/request/TimePaperLockRequestDto.java
@@ -22,5 +22,4 @@ public class TimePaperLockRequestDto {
   private LocalDateTime releaseDate;
 
 
-
 }
diff --git a/backend/src/main/java/com/timepaper/backend/domain/user/dto/request/LoginRequestDto.java b/backend/src/main/java/com/timepaper/backend/domain/user/dto/request/LoginRequestDto.java
@@ -1,5 +1,6 @@
 package com.timepaper.backend.domain.user.dto.request;
 
+import jakarta.validation.constraints.NotBlank;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
@@ -9,7 +10,9 @@
 @NoArgsConstructor
 public class LoginRequestDto {
 
+  @NotBlank(message = "이메일 입력은 필수입니다.")
   private String email;
+  @NotBlank(message = "비밀번호 입력은 필수입니다.")
   private String password;
 
 }
diff --git a/backend/src/main/java/com/timepaper/backend/domain/user/dto/request/SignUpRequestDto.java b/backend/src/main/java/com/timepaper/backend/domain/user/dto/request/SignUpRequestDto.java
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/controller/AuthController.java b/backend/src/main/java/com/timepaper/backend/global/auth/controller/AuthController.java
@@ -2,16 +2,16 @@
 
 import com.timepaper.backend.global.auth.dto.CertificationNumberRequestDto;
 import com.timepaper.backend.global.auth.dto.EmailCertificationRequestDto;
-import com.timepaper.backend.global.auth.dto.SignupDto;
+import com.timepaper.backend.global.auth.dto.SignupRequestDto;
 import com.timepaper.backend.global.auth.service.AuthService;
 import com.timepaper.backend.global.dto.ApiResponse;
 import jakarta.servlet.http.HttpServletResponse;
+import jakarta.validation.Valid;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.security.core.Authentication;
-import org.springframework.validation.annotation.Validated;
 import org.springframework.web.bind.annotation.CookieValue;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
@@ -30,21 +30,20 @@ public class AuthController {
   public void reissueToken(HttpServletResponse response,
       @CookieValue(value = "refresh_token", required = true) String refreshToken) {
 
-    log.info("refreshToken : {}", refreshToken);
     authService.reissueToken(response, refreshToken);
   }
 
   @PostMapping("/auth/logout")
   public void logout(HttpServletResponse response,
       @CookieValue(value = "refresh_token", required = false) String refreshToken,
       Authentication authentication) {
-    log.info("refreshToken : {}", refreshToken);
+
     authService.logout(response, refreshToken, authentication);
   }
 
   @PostMapping("/auth/email-verification-codes")
   public ResponseEntity<ApiResponse<Void>> requestEmailVerificationCode(
-      @RequestBody @Validated EmailCertificationRequestDto dto
+      @RequestBody @Valid EmailCertificationRequestDto dto
   ) {
     authService.requestEmailVerificationCode(dto);
 
@@ -54,7 +53,7 @@ public ResponseEntity<ApiResponse<Void>> requestEmailVerificationCode(
 
   @PostMapping("/auth/email-verification-codes/validate")
   public ResponseEntity<ApiResponse<Boolean>> checkEmailVerificationCode(
-      @RequestBody CertificationNumberRequestDto dto
+      @RequestBody @Valid CertificationNumberRequestDto dto
   ) {
     authService.checkEmailVerificationCode(dto);
 
@@ -63,7 +62,7 @@ public ResponseEntity<ApiResponse<Boolean>> checkEmailVerificationCode(
   }
 
   @PostMapping("/auth/signup")
-  public ResponseEntity<ApiResponse<Boolean>> signUp(@RequestBody @Validated SignupDto dto) {
+  public ResponseEntity<ApiResponse<Boolean>> signUp(@RequestBody @Valid SignupRequestDto dto) {
     authService.signUp(dto);
 
     return ResponseEntity.status(HttpStatus.NO_CONTENT)
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/dto/CertificationNumberRequestDto.java b/backend/src/main/java/com/timepaper/backend/global/auth/dto/CertificationNumberRequestDto.java
@@ -11,7 +11,7 @@ public class CertificationNumberRequestDto {
   @NotBlank
   private String email;
 
-  @NotBlank
+  @NotBlank(message = "인증 코드는 필수입니다.")
   private String authenticationCode;
 
 }
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/dto/EmailCertificationRequestDto.java b/backend/src/main/java/com/timepaper/backend/global/auth/dto/EmailCertificationRequestDto.java
@@ -7,7 +7,7 @@
 @Getter
 public class EmailCertificationRequestDto {
 
-  @NotBlank
+  @NotBlank(message = "이메일은 필수 입력입니다.")
   @Email
   private String email;
 }
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/dto/SignupRequestDto.java b/backend/src/main/java/com/timepaper/backend/global/auth/dto/SignupRequestDto.java
@@ -8,9 +8,9 @@
 import lombok.Getter;
 
 @Getter
-public class SignupDto {
+public class SignupRequestDto {
 
-  @Email
+  @Email(message = "이메일 형식이 틀렸습니다.")
   private String email;
 
   @Pattern(regexp = "^(?=.*[!@#$%^&*]).{8,}$")
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/filter/LoginFilter.java b/backend/src/main/java/com/timepaper/backend/global/auth/filter/LoginFilter.java
@@ -51,9 +51,7 @@ public Authentication attemptAuthentication(HttpServletRequest request,
     try {
       requestDto = objectMapper.readValue(request.getInputStream(),
           LoginRequestDto.class);
-
     } catch (IOException e) {
-      //여기 예외처리 어떻게 하징
       throw new GlobalException(ErrorCode.SERVER_ERROR);
     }
 
@@ -85,7 +83,7 @@ protected void unsuccessfulAuthentication(HttpServletRequest request,
       throws IOException, ServletException {
 
     log.info("로그인 검증 실패");
-    log.info("failed: {}", failed);
+    log.info("failed : {}", failed);
     log.info(failed.getMessage());
 
     ApiResponse<Object> apiResponse = null;
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/handler/CustomAccessDeniedHandler.java b/backend/src/main/java/com/timepaper/backend/global/auth/handler/CustomAccessDeniedHandler.java
@@ -2,6 +2,7 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.timepaper.backend.global.dto.ApiResponse;
+import com.timepaper.backend.global.exception.ErrorCode;
 import jakarta.servlet.ServletException;
 import jakarta.servlet.http.HttpServletRequest;
 import jakarta.servlet.http.HttpServletResponse;
@@ -24,7 +25,8 @@ public void handle(HttpServletRequest request, HttpServletResponse response,
     response.setContentType("application/json;charset=UTF-8");
     response.setStatus(HttpServletResponse.SC_FORBIDDEN);
 
-    ApiResponse<Void> errorResponse = ApiResponse.error("접근 권한이 없습니다.", "3002");
+    ApiResponse<Void> errorResponse = ApiResponse.error(ErrorCode.DEFAULT_FORBIDDEN.getMessage(),
+        ErrorCode.DEFAULT_FORBIDDEN.getCode());
     response.getWriter().write(objectMapper.writeValueAsString(errorResponse));
   }
 }
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/handler/CustomAuthenticationFailureHandler.java b/backend/src/main/java/com/timepaper/backend/global/auth/handler/CustomAuthenticationFailureHandler.java
@@ -1,5 +1,8 @@
 package com.timepaper.backend.global.auth.handler;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.timepaper.backend.global.dto.ApiResponse;
+import com.timepaper.backend.global.exception.ErrorCode;
 import jakarta.servlet.ServletException;
 import jakarta.servlet.http.HttpServletRequest;
 import jakarta.servlet.http.HttpServletResponse;
@@ -16,15 +19,22 @@
 @Slf4j
 public class CustomAuthenticationFailureHandler implements AuthenticationFailureHandler {
 
+  private final ObjectMapper objectMapper;
+
   @Override
   public void onAuthenticationFailure(HttpServletRequest request, HttpServletResponse response,
       AuthenticationException exception) throws IOException, ServletException {
+
     log.info("CustomAuthenticationFailureHandler");
-    log.info(exception.getMessage());
 
     if (exception instanceof BadCredentialsException e) {
-      log.info(e.getMessage());
-      log.info("BadCredentialsException ");
+      response.setContentType("application/json;charset=UTF-8");
+      response.setStatus(ErrorCode.INVALID_CREDENTIALS.getStatus().value());
+
+      ApiResponse<Void> errorResponse = ApiResponse.error(
+          ErrorCode.INVALID_CREDENTIALS.getMessage(),
+          ErrorCode.INVALID_CREDENTIALS.getCode());
+      response.getWriter().write(objectMapper.writeValueAsString(errorResponse));
     }
   }
 }
diff --git a/backend/src/main/java/com/timepaper/backend/global/auth/service/AuthService.java b/backend/src/main/java/com/timepaper/backend/global/auth/service/AuthService.java
@@ -4,7 +4,7 @@
 import com.timepaper.backend.domain.user.repository.UserRepository;
 import com.timepaper.backend.global.auth.dto.CertificationNumberRequestDto;
 import com.timepaper.backend.global.auth.dto.EmailCertificationRequestDto;
-import com.timepaper.backend.global.auth.dto.SignupDto;
+import com.timepaper.backend.global.auth.dto.SignupRequestDto;
 import com.timepaper.backend.global.auth.token.service.RefreshTokenService;
 import com.timepaper.backend.global.auth.token.util.JWTUtil;
 import com.timepaper.backend.global.auth.token.util.RefreshTokenUtil;
@@ -123,7 +123,7 @@ public void checkEmailVerificationCode(CertificationNumberRequestDto dto) {
 
 
   @Transactional
-  public void signUp(SignupDto dto) {
+  public void signUp(SignupRequestDto dto) {
     boolean isAuthenticatedEmail = Boolean.parseBoolean(
         redisTemplate.opsForValue().get(dto.getEmail())
     );
diff --git a/backend/src/main/java/com/timepaper/backend/global/config/SecurityConfig.java b/backend/src/main/java/com/timepaper/backend/global/config/SecurityConfig.java
@@ -25,6 +25,7 @@ public class SecurityConfig {
   private final LoginFilter loginFilter;
   private final JwtAuthenticationEntryPoint jwtAuthenticationEntryPoint;
   private final CustomAccessDeniedHandler accessDeniedHandler;
+  private final CustomAuthenticationFailureHandler authenticationFailureHandler;
 
   @Bean
   public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
@@ -44,7 +45,7 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
         )
         .addFilterAt(loginFilter, UsernamePasswordAuthenticationFilter.class)
         .formLogin(form -> form
-            .failureHandler(new CustomAuthenticationFailureHandler()))
+            .failureHandler(authenticationFailureHandler))
         .addFilterBefore(jwtAuthenticationFilter, UsernamePasswordAuthenticationFilter.class)
         .exceptionHandling(exception -> exception
             .authenticationEntryPoint(jwtAuthenticationEntryPoint)
diff --git a/backend/src/main/java/com/timepaper/backend/global/exception/handler/GlobalExceptionHandler.java b/backend/src/main/java/com/timepaper/backend/global/exception/handler/GlobalExceptionHandler.java
@@ -3,7 +3,10 @@
 import com.timepaper.backend.global.dto.ApiResponse;
 import com.timepaper.backend.global.exception.ErrorCode;
 import com.timepaper.backend.global.exception.custom.common.GlobalException;
+import java.util.List;
+import java.util.stream.Collectors;
 import org.springframework.http.ResponseEntity;
+import org.springframework.validation.FieldError;
 import org.springframework.web.bind.MethodArgumentNotValidException;
 import org.springframework.web.bind.annotation.ExceptionHandler;
 import org.springframework.web.bind.annotation.RestControllerAdvice;
@@ -22,9 +25,20 @@ public ResponseEntity<ApiResponse<Object>> exceptionHandler(GlobalException ex)
   @ExceptionHandler(MethodArgumentNotValidException.class)
   public ResponseEntity<ApiResponse<Object>> methodArgumentNotValidHandler(
       MethodArgumentNotValidException ex) {
-    return ResponseEntity.status(ErrorCode.INVALID_INPUT.getStatus())
-        .body(ApiResponse
-            .error(ErrorCode.INVALID_INPUT.getMessage(), ErrorCode.INVALID_INPUT.getCode()));
+
+    List<String> errorMessages = ex.getBindingResult().getFieldErrors()
+        .stream()
+        .map(FieldError::getDefaultMessage)
+        .collect(Collectors.toList());
+
+    String errorMessage = errorMessages.isEmpty()
+        ? ErrorCode.INVALID_INPUT.getMessage()
+        : errorMessages.getFirst();
+
+    return ResponseEntity
+        .status(ErrorCode.INVALID_INPUT.getStatus())
+        .body(ApiResponse.error(errorMessage,
+            ErrorCode.INVALID_INPUT.getCode()));
   }
 
   @ExceptionHandler(MaxUploadSizeExceededException.class)
@@ -36,6 +50,9 @@ public ResponseEntity<ApiResponse<Object>> malUploadSizeExceededHandler(
                 ErrorCode.PAYLOAD_TOO_LARGE.getCode()));
   }
 
+  /**
+   * 최종 처리는 배포 마지막에
+   */
 //  @ExceptionHandler(RuntimeException.class)
 //  public ResponseEntity<ApiResponse<Object>> exceptionHandler(RuntimeException ex) {
 //    return ResponseEntity.status(ErrorCode.SERVER_ERROR.getStatus())
diff --git a/frontend/src/pages/login/Login.jsx b/frontend/src/pages/login/Login.jsx
@@ -18,7 +18,7 @@ export default function Login() {
   const location = useLocation();
   const { isLoggedIn } = useSelector((state) => state.auth);
 
-  const handleLoginButtonClick = async (event) => {
+  const handleLoginButtonClick = (event) => {
     setIsLoginButtonEnable(false);
     event.preventDefault();
     (async () => {

Original file line number	Diff line number	Diff line change
`@@ -22,5 +22,4 @@ public class TimePaperLockRequestDto {`
`22`	`22`	`private LocalDateTime releaseDate;`
`23`	`23`
`24`	`24`
`25`		`-`
`26`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ public class CertificationNumberRequestDto {`
`11`	`11`	`@NotBlank`
`12`	`12`	`private String email;`
`13`	`13`
`14`		`- @NotBlank`
	`14`	`+ @NotBlank(message = "인증 코드는 필수입니다.")`
`15`	`15`	`private String authenticationCode;`
`16`	`16`
`17`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`@Getter`
`8`	`8`	`public class EmailCertificationRequestDto {`
`9`	`9`
`10`		`- @NotBlank`
	`10`	`+ @NotBlank(message = "이메일은 필수 입력입니다.")`
`11`	`11`	`@Email`
`12`	`12`	`private String email;`
`13`	`13`	`}`