use playwright as default convertor

Author: PaleNeutron

.github/workflows/python-package.yml

@@ -106,7 +106,7 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip wheel
-        pip install pytest pytest-asyncio matplotlib selenium jupyter pandoc playwright
+        pip install pytest pytest-asyncio matplotlib jupyter pandoc playwright selenium
         pip install . --upgrade
     - name: mac nbconvert patch fix # this is a tmp fix, related to https://github.com/jupyter/nbconvert/issues/1773
       if: ${{ startsWith(matrix.os, 'macos') }}

dataframe_image/_browser_pdf.py

@@ -7,7 +7,7 @@
 import socket
 from pathlib import Path
 from subprocess import Popen
-from tempfile import mkstemp
+from tempfile import TemporaryDirectory, mkstemp
 
 import aiohttp
 from nbconvert.exporters import HTMLExporter
@@ -86,32 +86,33 @@ async def main(file_name, p, debug_port):
 
 
 def get_launch_args():
-    # temp_dir = TemporaryDirectory()
-    temp_dir_name = os.path.abspath(".")
-    args = [
-        "--headless",
-        "--enable-logging",
-        "--disable-gpu",
-        "--run-all-compositor-stages-before-draw",
-        "--remote-allow-origins=*",
-        "--enable-features=NetworkService",
-        f"--crash-dumps-dir={temp_dir_name}",
-        "about:blank",
-    ]
-    if (
-        os.environ.get("NO_SANDBOX", False)
-        or platform.system().lower() != "windows"
-        and os.geteuid() == 0
-    ):
-        args.append("--no-sandbox")
-    return args
+    with TemporaryDirectory() as temp_dir:
+        temp_dir_name = os.path.abspath(".")
+        args = [
+            "--headless",
+            "--enable-logging",
+            "--disable-gpu",
+            "--run-all-compositor-stages-before-draw",
+            "--enable-features=NetworkService",
+            f"--crash-dumps-dir={temp_dir_name}",
+            f"--user-data-dir={temp_dir}",
+            "about:blank",
+        ]
+        if (
+            os.environ.get("NO_SANDBOX", False)
+            or platform.system().lower() != "windows"
+            and os.geteuid() == 0
+        ):
+            args.append("--no-sandbox")
+        return args
 
 
 # deprecated
 def launch_chrome(debug_port):
     chrome_path = get_chrome_path()
     args = [chrome_path] + get_launch_args() + [f"--remote-debugging-port={debug_port}"]
     p = Popen(args=args)
+    logging.debug(f"Chrome process started with PID: {p.pid}")
     return p
 
 

dataframe_image/_pandas_accessor.py

@@ -73,7 +73,7 @@ def prepare_converter(
     max_cols=None,
     table_conversion: Literal[
         "chrome", "matplotlib", "html2image", "playwright", "selenium"
-    ] = "chrome",
+    ] = "playwright",
     chrome_path=None,
     dpi=None,
     use_mathjax=False,
@@ -187,7 +187,7 @@ def export(
     max_cols=None,
     table_conversion: Literal[
         "chrome", "matplotlib", "html2image", "playwright", "selenium"
-    ] = "chrome",
+    ] = "playwright",
     chrome_path=None,
     dpi=None,
     use_mathjax=False,
@@ -234,7 +234,7 @@ async def export_async(
     max_cols=None,
     table_conversion: Literal[
         "chrome", "matplotlib", "html2image", "playwright_async", "selenium"
-    ] = "chrome",
+    ] = "playwright_async",
     chrome_path=None,
     dpi=None,
     use_mathjax=False,

dataframe_image/_version.py

@@ -1 +1 @@
-__version__ = "0.2.5.dev8+g18a693c.d20241008"
+__version__ = "0.2.7.dev9+gae0e83b.d20250129"