Skip to content

Commit d0fe738

Browse files
committed
fix path problem
1 parent 46ea4c7 commit d0fe738

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

dataframe_image/_browser_pdf.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,9 @@ def get_pdf_data(file_name, p):
122122

123123
def get_pdf_data_chromecontroller(file_name):
124124
additional_options = get_launch_args()
125+
# ChromeContext will shlex.split binary, so add quote to it
125126
with ChromeController.ChromeContext(
126-
binary=get_chrome_path(), additional_options=additional_options
127+
binary=f'"{get_chrome_path()}"', additional_options=additional_options
127128
) as cr:
128129
# Do a blocking navigate to a URL, and get the page content as served by the remote
129130
# server, with no modification by local javascript (if applicable)

tests/test_convert.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def tname_to_filename(test_name:str):
2626
@pytest.mark.parametrize("execute", executes, ids=["executed", ""])
2727
@pytest.mark.parametrize("no_input", no_input, ids=["no_input", ""])
2828
class TestConvertPDF:
29-
def test_same_folder(self, request, filename, use, execute, no_input):
29+
def test_to_pdf(self, request, filename, use, execute, no_input):
3030
document_name = tname_to_filename(request.node.name)
3131
convert(
3232
filename, to="pdf", use=use, execute=execute, document_name=document_name, no_input=no_input
@@ -37,7 +37,7 @@ def test_same_folder(self, request, filename, use, execute, no_input):
3737
@pytest.mark.parametrize("execute", executes, ids=["executed", ""])
3838
@pytest.mark.parametrize("no_input", no_input, ids=["no_input", ""])
3939
class TestConvertMD:
40-
def test_same_folder(self, request, filename, execute, no_input):
40+
def test_to_md(self, request, filename, execute, no_input):
4141
document_name = tname_to_filename(request.node.name)
4242
convert(filename, to="md", execute=execute, document_name=document_name, no_input=no_input)
4343

0 commit comments

Comments
 (0)