Skip to content
This repository was archived by the owner on May 8, 2023. It is now read-only.

Issue on pages that have elements with ids that start with numbers #7

@espspinix

Description

@espspinix

On version 3.12 I cannot add markers on some pages. The error I see in the console is:
Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '#43ce' is not a valid selector. ( example page )

To me it seems that the error is here:

if (node.ownerDocument.querySelectorAll(`#${node.id}`).length === 1) {

As document.querySelectorAll has problems identifying ids that start with numbers.

A proposed fix from stackoverflow: https://stackoverflow.com/a/20306237/4489917

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions