Skip to content

Commit 3e38560

Browse files
ben-ednaspoorcc
authored andcommitted
Fix pylint issues
1 parent 3fe184a commit 3e38560

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

dfetch/project/git.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,11 @@ def _fetch_impl(self, version: Version) -> Version:
7878
]
7979

8080
self._local_repo.checkout_version(
81-
self.remote, rev_or_branch_or_tag, self.source, license_globs, self.ignore
81+
remote=self.remote,
82+
version=rev_or_branch_or_tag,
83+
src=self.source,
84+
must_keeps=license_globs,
85+
ignore=self.ignore,
8286
)
8387

8488
safe_rmtree(os.path.join(self.local_path, self._local_repo.METADATA_DIR))

dfetch/project/svn.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ def externals() -> List[External]:
4949
externals = []
5050
path_pattern = r"([^\s^-]+)\s+-"
5151
for entry in result.stdout.decode().split(os.linesep * 2):
52-
match = None
52+
match: Optional[re.Match[str]] = None
53+
local_path: str = ""
5354
for match in re.finditer(path_pattern, entry):
5455
pass
5556
if match:

dfetch/vcs/git.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,12 @@ def is_git(self) -> bool:
163163

164164
def checkout_version( # pylint: disable=too-many-arguments
165165
self,
166+
*,
166167
remote: str,
167168
version: str,
168-
src: Optional[str],
169-
must_keeps: Optional[List[str]],
170-
ignore: Optional[Sequence[str]],
169+
src: Optional[str] = None,
170+
must_keeps: Optional[List[str]] = None,
171+
ignore: Optional[Sequence[str]] = None,
171172
) -> None:
172173
"""Checkout a specific version from a given remote.
173174

0 commit comments

Comments
 (0)