chore: remove cli arg and harcode const

Author: sa-idx-admin

src/cli.rs

@@ -20,7 +20,7 @@ use reqwest::Url;
 
 use crate::{
     core::{AUTHOR_NAME, SERVICE_NAME},
-    routing::{domain::CanisterAlias, RequestType},
+    routing::{RequestType, domain::CanisterAlias},
 };
 
 /// Clap does not support prefixes due to macro limitations.
@@ -320,9 +320,6 @@ pub struct Metrics {
     /// Where to listen for Prometheus metrics scraping
     #[clap(env, long)]
     pub metrics_listen: Option<SocketAddr>,
-    /// How frequently to refresh statistics about API boundary nodes
-    #[clap(env, long, default_value = "30s", value_parser = parse_duration)]
-    pub api_boundary_nodes_stats_refresh_interval: Duration,
 }
 
 #[derive(Args)]

src/routing/ic/route_provider.rs

@@ -1,6 +1,6 @@
-use std::sync::Arc;
-use async_trait::async_trait;
+use std::{sync::Arc, time::Duration};
 use anyhow::anyhow;
+use async_trait::async_trait;
 use candid::Principal;
 use ic_agent::agent::http_transport::reqwest_transport::reqwest::Client as AgentClient;
 use ic_agent::agent::route_provider::{
@@ -21,6 +21,8 @@ use crate::routing::ic::{
     nodes_fetcher::{MAINNET_ROOT_SUBNET_ID, NodesFetcher},
 };
 
+pub const API_BOUNDARY_NODES_STATS_REFRESH_INTERVAL: Duration = Duration::from_secs(30);
+
 pub async fn setup_route_provider(
     urls: &[Url],
     ic_use_discovery: bool,
@@ -115,7 +117,9 @@ impl Run for ApiBoundaryNodesStats {
     async fn run(&self, _: CancellationToken) -> Result<(), anyhow::Error> {
         let stats = self.route_provider.routes_stats();
         self.metrics.total_nodes.set(stats.total as i64);
-        self.metrics.healthy_nodes.set(stats.healthy.unwrap_or(0) as i64);
+        self.metrics
+            .healthy_nodes
+            .set(stats.healthy.unwrap_or(0) as i64);
         Ok(())
     }
 }

src/routing/mod.rs

@@ -21,7 +21,7 @@ use domain::{CustomDomainStorage, DomainResolver, ProvidesCustomDomains};
 use fqdn::FQDN;
 use http::{method::Method, uri::PathAndQuery, StatusCode, Uri};
 use ic_agent::agent::route_provider::RouteProvider;
-use ic::route_provider::ApiBoundaryNodesStats;
+use ic::route_provider::{ApiBoundaryNodesStats, API_BOUNDARY_NODES_STATS_REFRESH_INTERVAL};
 use ic_bn_lib::{
     http::{
         cache::{Cache, KeyExtractorUriRange, Opts},
@@ -322,7 +322,7 @@ pub fn setup_router(
     tasks.add_interval(
         "api_boundary_nodes_stats",
         Arc::new(ApiBoundaryNodesStats::new(route_provider.clone(), registry)),
-        cli.metrics.api_boundary_nodes_stats_refresh_interval,
+        API_BOUNDARY_NODES_STATS_REFRESH_INTERVAL,
     );
 
     // Prepare the states