Skip to content

Commit 018288c

Browse files
authored
fix(IDX): move checkout step (#7703)
This moves the checkout step to the front for `Lock Generate` and `Generate Config Fixtures` since the manual run needs to know which commit to check for file changes on.
1 parent ef93033 commit 018288c

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

.github/workflows/ci-pr-only.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,18 @@ jobs:
9393
env:
9494
CI_EVENT_NAME: ${{ github.event_name }}
9595
steps:
96+
- name: Create GitHub App Token
97+
uses: actions/create-github-app-token@v1
98+
id: app-token
99+
with:
100+
app-id: ${{ vars.PR_CREATION_BOT_APP_ID }}
101+
private-key: ${{ secrets.PR_CREATION_BOT_PRIVATE_KEY }}
102+
- name: Checkout
103+
uses: actions/checkout@v4
104+
with:
105+
repository: ${{ github.event.pull_request.head.repo.full_name }}
106+
ref: ${{ github.event.pull_request.head.ref }}
107+
token: ${{ steps.app-token.outputs.token }}
96108
- name: Filter Relevant Files
97109
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3
98110
id: filter
@@ -107,18 +119,6 @@ jobs:
107119
- '**/*.lock'
108120
- '**/*.rs'
109121
- '**/*.toml'
110-
- name: Create GitHub App Token
111-
uses: actions/create-github-app-token@v1
112-
id: app-token
113-
with:
114-
app-id: ${{ vars.PR_CREATION_BOT_APP_ID }}
115-
private-key: ${{ secrets.PR_CREATION_BOT_PRIVATE_KEY }}
116-
- name: Checkout
117-
uses: actions/checkout@v4
118-
with:
119-
repository: ${{ github.event.pull_request.head.repo.full_name }}
120-
ref: ${{ github.event.pull_request.head.ref }}
121-
token: ${{ steps.app-token.outputs.token }}
122122
- name: Run Lock Generate
123123
id: lock-generate
124124
if: steps.filter.outputs.lock-generate == 'true'
@@ -132,14 +132,6 @@ jobs:
132132
env:
133133
CI_EVENT_NAME: ${{ github.event_name }}
134134
steps:
135-
- name: Filter Relevant Files
136-
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3
137-
id: filter
138-
with:
139-
filters: |
140-
generate-config-fixtures:
141-
- '.github/workflows/ci-pr-only.yml'
142-
- 'rs/ic_os/config_types/**'
143135
- name: Create GitHub App Token
144136
uses: actions/create-github-app-token@v1
145137
id: app-token
@@ -152,6 +144,14 @@ jobs:
152144
repository: ${{ github.event.pull_request.head.repo.full_name }}
153145
ref: ${{ github.event.pull_request.head.ref }}
154146
token: ${{ steps.app-token.outputs.token }}
147+
- name: Filter Relevant Files
148+
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3
149+
id: filter
150+
with:
151+
filters: |
152+
generate-config-fixtures:
153+
- '.github/workflows/ci-pr-only.yml'
154+
- 'rs/ic_os/config_types/**'
155155
- name: Run Generate Config Fixtures
156156
id: generate-config-fixtures
157157
if: steps.filter.outputs.generate-config-fixtures == 'true'

0 commit comments

Comments
 (0)