Merge branch 'NNS1-1906-p1' into 'master'

NNS1-1906: Split the NNS Root canister crate into an interface and canister crate

The new structure resembles 

```
rs/nns/handlers/root/impl/
rs/nns/handlers/root/impl/BUILD.bazel
rs/nns/handlers/root/impl/canister/
rs/nns/handlers/root/impl/canister/canister.rs
rs/nns/handlers/root/impl/canister/root.did
rs/nns/handlers/root/impl/canister/src/
rs/nns/handlers/root/impl/canister/tests/
rs/nns/handlers/root/impl/canister/proto/
rs/nns/handlers/root/impl/canister/protobuf_generator/


rs/nns/handlers/root/interface/
rs/nns/handlers/root/interface/BUILD.bazel
rs/nns/handlers/root/interface/src/lib.rs
rs/nns/handlers/root/interface/src/client.rs
```

The interface package should contain the Request and Response types of the NNS root canister and should be depended on by other canisters (such as governance, SNS-W, etc) instead of directly on the implementation of a canister. This solves the circular dependency problem of canisters calling each other within the monorepo. 

See merge request dfinity-lab/public/ic!12554

Author: Daniel Thurau

Cargo.lock

@@ -156,8 +156,9 @@ members = [
   "rs/nns/governance",
   "rs/nns/governance/protobuf_generator",
   "rs/nns/handlers/lifeline",
-  "rs/nns/handlers/root",
-  "rs/nns/handlers/root/protobuf_generator",
+  "rs/nns/handlers/root/impl",
+  "rs/nns/handlers/root/impl/protobuf_generator",
+  "rs/nns/handlers/root/interface",
   "rs/nns/identity",
   "rs/nns/init",
   "rs/nns/inspector",

Cargo.toml

@@ -7,7 +7,7 @@ build:
     - rs/nervous_system/proto/proto
     - rs/nns/common/proto
     - rs/nns/gtc/proto Temporarily removed because a PR was reverted and then un-reverted
-    - rs/nns/handlers/root/proto
+    - rs/nns/handlers/root/impl/proto
     - rs/nns/governance/proto
     - rs/protobuf/def
     - rs/rosetta-api/icp_ledger/proto

buf.yaml

@@ -351,7 +351,7 @@ def test_get_findings_for_bazel_repo():
                            fix_version_for_vulnerability={}),
                 Dependency(id='https://crates.io/crates/x509-parser', name='x509-parser', version='0.12.0',
                            fix_version_for_vulnerability={})]
-            assert findings[0].projects == ['rs/backup', 'rs/canister_client/sender', 'rs/crypto', 'rs/crypto/ecdsa_secp256k1', 'rs/crypto/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/cose', 'rs/crypto/internal/crypto_lib/basic_sig/der_utils', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256k1', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/ed25519', 'rs/crypto/internal/crypto_lib/basic_sig/iccsa', 'rs/crypto/internal/crypto_lib/basic_sig/rsa_pkcs1', 'rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/der_utils', 'rs/crypto/internal/crypto_service_provider', 'rs/crypto/node_key_validation', 'rs/crypto/node_key_validation/tls_cert_validation', 'rs/crypto/utils/basic_sig', 'rs/elastic_common_schema', 'rs/ic_p8s_service_discovery/log', 'rs/monitoring/logger', 'rs/monitoring/onchain_observability/adapter', 'rs/nervous_system/common', 'rs/nns/cmc', 'rs/nns/governance', 'rs/nns/gtc', 'rs/nns/handlers/root', 'rs/nns/sns-wasm', 'rs/prep', 'rs/registry/canister', 'rs/registry/nns_data_provider', 'rs/rosetta-api', 'rs/rosetta-api/icrc1/ledger/sm-tests', 'rs/rosetta-api/ledger_canister_blocks_synchronizer', 'rs/rosetta-api/ledger_canister_blocks_synchronizer/test_utils', 'rs/scenario_tests', 'rs/sns/governance', 'rs/sns/root', 'rs/sns/swap', 'rs/tests', 'rs/types/types', 'rs/validator', 'rs/validator/http_request_test_utils']
+            assert findings[0].projects == ['rs/backup', 'rs/canister_client/sender', 'rs/crypto', 'rs/crypto/ecdsa_secp256k1', 'rs/crypto/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/cose', 'rs/crypto/internal/crypto_lib/basic_sig/der_utils', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256k1', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/ed25519', 'rs/crypto/internal/crypto_lib/basic_sig/iccsa', 'rs/crypto/internal/crypto_lib/basic_sig/rsa_pkcs1', 'rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/der_utils', 'rs/crypto/internal/crypto_service_provider', 'rs/crypto/node_key_validation', 'rs/crypto/node_key_validation/tls_cert_validation', 'rs/crypto/utils/basic_sig', 'rs/elastic_common_schema', 'rs/ic_p8s_service_discovery/log', 'rs/monitoring/logger', 'rs/monitoring/onchain_observability/adapter', 'rs/nervous_system/common', 'rs/nns/cmc', 'rs/nns/governance', 'rs/nns/gtc', 'rs/nns/handlers/root/impl', 'rs/nns/handlers/root/interface', 'rs/nns/sns-wasm', 'rs/prep', 'rs/registry/canister', 'rs/registry/nns_data_provider', 'rs/rosetta-api', 'rs/rosetta-api/icrc1/ledger/sm-tests', 'rs/rosetta-api/ledger_canister_blocks_synchronizer', 'rs/rosetta-api/ledger_canister_blocks_synchronizer/test_utils', 'rs/scenario_tests', 'rs/sns/governance', 'rs/sns/root', 'rs/sns/swap', 'rs/tests', 'rs/types/types', 'rs/validator', 'rs/validator/http_request_test_utils']
             assert findings[0].score == -1
 
             # unique fields for second finding
@@ -405,7 +405,7 @@ def test_get_findings_for_bazel_repo():
                                 fix_version_for_vulnerability={}),
                      Dependency(id='https://crates.io/crates/x509-parser', name='x509-parser', version='0.12.0',
                                 fix_version_for_vulnerability={})]
-            assert findings[2].projects == ['rs/backup', 'rs/canister_client/sender', 'rs/crypto', 'rs/crypto/ecdsa_secp256k1', 'rs/crypto/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/cose', 'rs/crypto/internal/crypto_lib/basic_sig/der_utils', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256k1', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/ed25519', 'rs/crypto/internal/crypto_lib/basic_sig/iccsa', 'rs/crypto/internal/crypto_lib/basic_sig/rsa_pkcs1', 'rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/der_utils', 'rs/crypto/internal/crypto_service_provider', 'rs/crypto/node_key_validation', 'rs/crypto/node_key_validation/tls_cert_validation', 'rs/crypto/utils/basic_sig', 'rs/elastic_common_schema', 'rs/ic_p8s_service_discovery/log', 'rs/monitoring/logger', 'rs/monitoring/onchain_observability/adapter', 'rs/nervous_system/common', 'rs/nns/cmc', 'rs/nns/governance', 'rs/nns/gtc', 'rs/nns/handlers/root', 'rs/nns/sns-wasm', 'rs/prep', 'rs/registry/canister', 'rs/registry/nns_data_provider', 'rs/replica', 'rs/rosetta-api', 'rs/rosetta-api/icrc1/ledger/sm-tests', 'rs/rosetta-api/ledger_canister_blocks_synchronizer', 'rs/rosetta-api/ledger_canister_blocks_synchronizer/test_utils', 'rs/scenario_tests', 'rs/sns/governance', 'rs/sns/root', 'rs/sns/swap', 'rs/tests', 'rs/types/types', 'rs/validator', 'rs/validator/http_request_test_utils']
+            assert findings[2].projects == ['rs/backup', 'rs/canister_client/sender', 'rs/crypto', 'rs/crypto/ecdsa_secp256k1', 'rs/crypto/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/cose', 'rs/crypto/internal/crypto_lib/basic_sig/der_utils', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256k1', 'rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256r1', 'rs/crypto/internal/crypto_lib/basic_sig/ed25519', 'rs/crypto/internal/crypto_lib/basic_sig/iccsa', 'rs/crypto/internal/crypto_lib/basic_sig/rsa_pkcs1', 'rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/der_utils', 'rs/crypto/internal/crypto_service_provider', 'rs/crypto/node_key_validation', 'rs/crypto/node_key_validation/tls_cert_validation', 'rs/crypto/utils/basic_sig', 'rs/elastic_common_schema', 'rs/ic_p8s_service_discovery/log', 'rs/monitoring/logger', 'rs/monitoring/onchain_observability/adapter', 'rs/nervous_system/common', 'rs/nns/cmc', 'rs/nns/governance', 'rs/nns/gtc', 'rs/nns/handlers/root/impl', 'rs/nns/handlers/root/interface', 'rs/nns/sns-wasm', 'rs/prep', 'rs/registry/canister', 'rs/registry/nns_data_provider', 'rs/replica', 'rs/rosetta-api', 'rs/rosetta-api/icrc1/ledger/sm-tests', 'rs/rosetta-api/ledger_canister_blocks_synchronizer', 'rs/rosetta-api/ledger_canister_blocks_synchronizer/test_utils', 'rs/scenario_tests', 'rs/sns/governance', 'rs/sns/root', 'rs/sns/swap', 'rs/tests', 'rs/types/types', 'rs/validator', 'rs/validator/http_request_test_utils']
             assert findings[2].score == 6
 
 class MockBazelCargoExecutor(BazelCargoExecutor):