Skip to content

Commit 234d190

Browse files
committed
[IDX-2606]: Use the image from bazel cache for scalability tests. The change will decrease usage of s3 and will make scalability tests to be ready for using synthetic ic-os version. See merge request dfinity-lab/public/ic!12618
2 parents fda3933 + 7f4c979 commit 234d190

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

scalability/BUILD.bazel

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,6 @@ py_binary(
236236
srcs = ["common/tests/e2e-scalability-tests.py"],
237237
data = [
238238
":artifacts",
239-
"//ic-os/guestos/envs/dev:hash_and_upload_update-img",
240-
"//ic-os/guestos/envs/dev:hash_and_upload_disk-img",
241239
"//ic-os:scripts/build-bootstrap-config-image.sh",
242240
"//rs/tests:create-universal-vm-config-image.sh",
243241
"common/flamegraph.gz",
@@ -275,11 +273,15 @@ sh_test(
275273
data = [
276274
":e2e-scalability-tests",
277275
"//ic-os:scripts/build-bootstrap-config-image.sh",
276+
"//ic-os/guestos/envs/dev:disk-img.tar.zst.cas-url",
277+
"//ic-os/guestos/envs/dev:disk-img.tar.zst.sha256",
278278
"//ic-os/guestos/envs/dev:version.txt",
279279
],
280280
env = {
281281
"E2E_TEST_BIN": "$(rootpath :e2e-scalability-tests)",
282282
"IC_OS_VERSION_FILE": "$(rootpath //ic-os/guestos/envs/dev:version.txt)",
283+
"IC_OS_IMAGE_URL": "$(rootpath //ic-os/guestos/envs/dev:disk-img.tar.zst.cas-url)",
284+
"IC_OS_IMAGE_SHA256SUM": "$(rootpath //ic-os/guestos/envs/dev:disk-img.tar.zst.sha256)",
283285
},
284286
env_inherit = [
285287
"CI_PROJECT_DIR",

scalability/common/tests/e2e-scalability-tests.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
gflags.DEFINE_string("ic_os_version", None, "Version of the guest OS to boot")
2121
gflags.MarkFlagAsRequired("ic_os_version")
2222
gflags.DEFINE_string("artifacts_path", "", "Path to the artifacts directory")
23+
gflags.DEFINE_string("image_url", "", "url of ic-os guestos dev disk image. Constructed from ic_os version if not set.")
24+
gflags.DEFINE_string("image_sha256sum", "", "sha256 sum of ic-os guestos dev disk image. Constructed from ic_os version if not set.")
2325

2426

2527
def run(args):
@@ -41,11 +43,11 @@ def main(argv):
4143

4244
version = farm.Farm.latest_with_disk_image() if FLAGS.ic_os_version == "latest" else FLAGS.ic_os_version
4345
farm_instance = farm.Farm(FLAGS.artifacts_path, [1, 1], version)
46+
image_url = farm.image_url_from_git_commit(version) if FLAGS.image_url is None else FLAGS.image_url
47+
image_sha256sum = farm.sha256_for_image(version) if FLAGS.image_sha256sum is None else FLAGS.image_sha256sum
4448
try:
4549
farm_instance.create_farm_group()
46-
farm_instance.create_vms_from_ic_os_image_via_url(
47-
farm.image_url_from_git_commit(version), farm.sha256_for_image(version)
48-
)
50+
farm_instance.create_vms_from_ic_os_image_via_url(image_url, image_sha256sum)
4951
farm_instance.prepare_and_register_config_image()
5052

5153
farm_instance.create_prometheus_vm()

scalability/common/tests/e2e-scalability-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ fi
1717

1818
exec "${E2E_TEST_BIN}" \
1919
--ic_os_version "$(cat "${IC_OS_VERSION_FILE}")" \
20+
--image_url "$(cat "${IC_OS_IMAGE_URL}")" \
21+
--image_sha256sum "$(cat "${IC_OS_IMAGE_SHA256SUM}")" \
2022
--artifacts_path "scalability/artifacts/release/" \
2123
--nns_canisters "scalability/artifacts/canisters/" \
2224
--install_nns_bin "scalability/artifacts/release/ic-nns-init" \

0 commit comments

Comments
 (0)