Merge branch 'FI-735' into 'master'

feat(FI-735) [icrc index-ng] fix oldest_tx_id and add tests

1. efficient way to find oldest_tx_id
2. add tests 

See merge request dfinity-lab/public/ic!12639

Author: MarioDfinity

rs/rosetta-api/icrc1/index-ng/src/main.rs

@@ -592,17 +592,19 @@ fn encoded_block_bytes_to_flat_transaction(
 }
 
 fn get_oldest_tx_id(account: Account) -> Option<BlockIndex64> {
-    // TODO: there is no easy way to get the oldest_tx_id so we traverse
-    //       all the transaction of the account for now. This will be
-    //       fixed in future by storying the oldest_tx_id somewhere and
-    //       replace the body of this function.
-    let first_key = account_block_ids_key(account, u64::MAX);
+    // There is no easy way to get the oldest index for an account
+    // in one step. Instead, we do it in two steps:
+    // 1. check if index 0 is owned by the account
+    // 2. if not then return the oldest index of the account that
+    //    is not 0 via iter_upper_bound
     let last_key = account_block_ids_key(account, 0);
     with_account_block_ids(|account_block_ids| {
-        account_block_ids
-            .range(first_key..=last_key)
-            .last()
-            .map(|(k, _)| k.1 .0)
+        account_block_ids.get(&last_key).map(|_| 0).or_else(|| {
+            account_block_ids
+                .iter_upper_bound(&last_key)
+                .find(|((account_bytes, _), _)| account_bytes == &last_key.0)
+                .map(|(key, _)| key.1 .0)
+        })
     })
 }
 

rs/rosetta-api/icrc1/index-ng/tests/tests.rs

@@ -783,3 +783,68 @@ fn test_post_upgrade_start_timer() {
     transfer(env, ledger_id, account(1, 0), account(2, 0), 2_000_000);
     wait_until_sync_is_completed(env, index_id, ledger_id);
 }
+
+#[test]
+fn test_oldest_tx_id() {
+    let env = &StateMachine::new();
+    let ledger_id = install_ledger(
+        env,
+        vec![(account(1, 0), 10_000_000)],
+        default_archive_options(),
+    );
+    let index_id = install_index(env, ledger_id);
+
+    // account(2, 0) and account(3, 0) have no transactions so oldest_tx_id should be None
+    for account in [account(2, 0), account(3, 0)] {
+        let oldest_tx_id =
+            get_account_transactions(env, index_id, account, None, u64::MAX).oldest_tx_id;
+        assert_eq!(None, oldest_tx_id);
+    }
+
+    // account(1, 0) oldest_tx_id is 0, i.e. the mint at ledger init
+    let oldest_tx_id =
+        get_account_transactions(env, index_id, account(1, 0), None, u64::MAX).oldest_tx_id;
+    assert_eq!(Some(0.into()), oldest_tx_id);
+
+    ////
+    // add one block for account(1, 0) and account(2, 0)
+    transfer(env, ledger_id, account(1, 0), account(2, 0), 1_000_000);
+    wait_until_sync_is_completed(env, index_id, ledger_id);
+
+    // account(1, 0) oldest_tx_id is still 0
+    let oldest_tx_id =
+        get_account_transactions(env, index_id, account(1, 0), None, u64::MAX).oldest_tx_id;
+    assert_eq!(Some(0.into()), oldest_tx_id);
+
+    // account(2, 0) oldest_tx_id is 1, i.e. the new transfer
+    let oldest_tx_id =
+        get_account_transactions(env, index_id, account(2, 0), None, u64::MAX).oldest_tx_id;
+    assert_eq!(Some(1.into()), oldest_tx_id);
+
+    // account(3, 0) oldest_tx_id is still None
+    let oldest_tx_id =
+        get_account_transactions(env, index_id, account(3, 0), None, u64::MAX).oldest_tx_id;
+    assert_eq!(None, oldest_tx_id);
+
+    ////
+    // add one block for account(1, 0) and account(2, 0)
+    // add the first block for account(3, 0)
+    transfer(env, ledger_id, account(1, 0), account(2, 0), 2_000_000);
+    transfer(env, ledger_id, account(1, 0), account(3, 0), 3_000_000);
+    wait_until_sync_is_completed(env, index_id, ledger_id);
+
+    // account(1, 0) oldest_tx_id is still 0
+    let oldest_tx_id =
+        get_account_transactions(env, index_id, account(1, 0), None, u64::MAX).oldest_tx_id;
+    assert_eq!(Some(0.into()), oldest_tx_id);
+
+    // account(2, 0) oldest_tx_id is still 1
+    let oldest_tx_id =
+        get_account_transactions(env, index_id, account(2, 0), None, u64::MAX).oldest_tx_id;
+    assert_eq!(Some(1.into()), oldest_tx_id);
+
+    // account(3, 0) oldest_tx_id is 3, i.e. the last block index
+    let oldest_tx_id =
+        get_account_transactions(env, index_id, account(3, 0), None, u64::MAX).oldest_tx_id;
+    assert_eq!(Some(3.into()), oldest_tx_id);
+}