lint

daniel-wong-dfinity-org · daniel-wong-dfinity-org · commit 58adb1eaa3de · 2026-04-08T13:50:54.000Z
diff --git a/rs/nns/governance/src/proposals/create_canister_and_install_code.rs b/rs/nns/governance/src/proposals/create_canister_and_install_code.rs
@@ -61,11 +61,10 @@ impl CreateCanisterAndInstallCode {
         }
 
         // Validate canister_settings.
-        if let Some(settings) = canister_settings {
-            if let Err(err) = RootCanisterSettings::try_from(settings) {
+        if let Some(settings) = canister_settings
+            && let Err(err) = RootCanisterSettings::try_from(settings) {
                 defects.push(err.error_message);
             }
-        }
 
         // Assemble (and return) final result.
         if !defects.is_empty() {

Original file line number	Diff line number	Diff line change
`@@ -61,11 +61,10 @@ impl CreateCanisterAndInstallCode {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`// Validate canister_settings.`
`64`		`- if let Some(settings) = canister_settings {`
`65`		`- if let Err(err) = RootCanisterSettings::try_from(settings) {`
	`64`	`+ if let Some(settings) = canister_settings`
	`65`	`+ && let Err(err) = RootCanisterSettings::try_from(settings) {`
`66`	`66`	`defects.push(err.error_message);`
`67`	`67`	`}`
`68`		`- }`
`69`	`68`
`70`	`69`	`// Assemble (and return) final result.`
`71`	`70`	`if !defects.is_empty() {`