Skip to content

Commit 71e657a

Browse files
committed
Merge branch 'levsha/-IDX-2606-make-ic-version-configurable-of-ic-os-images-' into 'master'
[IDX-2606] make ic version configurable of ic-os images. This change will allow to use syntetic stable version for dev images and/or non-release pipelines and therefore improve caching. See merge request dfinity-lab/public/ic!12575
2 parents 55c1f01 + b71b037 commit 71e657a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ic-os/defs.bzl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ load("//bazel:defs.bzl", "gzip_compress", "sha256sum2url", "zstd_compress")
99
load("//bazel:output_files.bzl", "output_files")
1010
load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
1111

12-
def icos_build(name, upload_prefix, image_deps, mode = None, malicious = False, upgrades = True, vuln_scan = True, visibility = None):
12+
def icos_build(name, upload_prefix, image_deps, mode = None, malicious = False, upgrades = True, vuln_scan = True, visibility = None, ic_version = "//bazel:version.txt"):
1313
"""
1414
Generic ICOS build tooling.
1515
@@ -22,6 +22,7 @@ def icos_build(name, upload_prefix, image_deps, mode = None, malicious = False,
2222
upgrades: if True, build upgrade images as well
2323
vuln_scan: if True, create targets for vulnerability scanning
2424
visibility: See Bazel documentation
25+
ic_version: the label pointing to the target that returns IC version
2526
"""
2627

2728
if mode == None:
@@ -40,7 +41,7 @@ def icos_build(name, upload_prefix, image_deps, mode = None, malicious = False,
4041

4142
copy_file(
4243
name = "copy_version_txt",
43-
src = "//bazel:version.txt",
44+
src = ic_version,
4445
out = "version.txt",
4546
allow_symlink = True,
4647
visibility = visibility,

0 commit comments

Comments
 (0)