Skip to content

Commit 75736bd

Browse files
authored
fix: Ignore failure to cleanup tmpdir (#8102)
It seems this happens when podman is still holding a handle in the dir. We hope to share the cache and builds soon with https://dfinity.atlassian.net/browse/NODE-1048, so that this cleanup is no longer necessary.
1 parent 04bbbe6 commit 75736bd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

toolchains/sysimage/proc_wrapper.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@ tmpfs_tmpdir=$(mktemp -d --tmpdir "icosbuildXXXX")
1212
sudo mount -t tmpfs none "${tmpfs_tmpdir}"
1313

1414
tmpdir=$(mktemp -d --tmpdir "icosbuildXXXX")
15-
trap 'sudo umount "${tmpfs_tmpdir}"; sudo rm -rf "$tmpdir" "${tmpfs_tmpdir}"' INT TERM EXIT
15+
# NOTE: Ignore failure to cleanup the directory for now. This should not be a problem after NODE-1048.
16+
trap 'sudo umount "${tmpfs_tmpdir}"; sudo rm -rf "$tmpdir" "${tmpfs_tmpdir}" || true' INT TERM EXIT
1617
TMPDIR="$tmpdir" TMPFS_TMPDIR="${tmpfs_tmpdir}" "$@"

0 commit comments

Comments
 (0)