Skip to content

Commit 838da84

Browse files
authored
fix: deflake //rs/tests/nested/nns_recovery:nr_local (#9303)
## Root Cause The test `//rs/tests/nested/nns_recovery:nr_local` flaked with: ``` Could not create message canister.: "Timeout while creating message canister" ``` `store_message` creates the canister with a single attempt that can time out under load. ## Fix Replace `store_message` with `store_message_with_retries`, which retries canister creation for up to 300s with 10s intervals, making it resilient to transient timeouts. --- This PR was created following the steps in `.claude/skills/fix-flaky-tests/SKILL.md`.
1 parent 89821ed commit 838da84

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rs/tests/nested/nns_recovery/common.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use ic_consensus_system_test_subnet_recovery::utils::{
99
use ic_consensus_system_test_utils::{
1010
impersonate_upstreams,
1111
node::await_subnet_earliest_topology_version_with_retries,
12-
rw_message::store_message,
12+
rw_message::store_message_with_retries,
1313
ssh_access::{
1414
AuthMean, disable_ssh_access_to_node, get_updatesubnetpayload_with_keys,
1515
update_subnet_record, wait_until_authentication_is_granted,
@@ -215,7 +215,7 @@ pub fn test(env: TestEnv, cfg: TestConfig) {
215215

216216
info!(logger, "Ensure NNS subnet is functional");
217217
let init_msg = "subnet recovery works!";
218-
let app_can_id = store_message(
218+
let app_can_id = store_message_with_retries(
219219
&nns_node.get_public_url(),
220220
nns_node.effective_canister_id(),
221221
init_msg,

0 commit comments

Comments
 (0)