Skip to content

Commit a4c1c9b

Browse files
kpop-dfinityIDX GitHub Automation
kpop-dfinity
and
IDX GitHub Automation
authored
chore: update rust to 1.88.0 (#6045)
# Changes 1. Removed long deprecated rls component, since it's been [removed from rust in 1.87.0](rust-lang/rust#126856) 2. disabled [uninlined_format_args](https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args) check - otherwise I would have to change essentially every file in the repo in this PR... - note that the lint[ has been moved back to `pedantic` in the cargo clippy](rust-lang/rust-clippy#15287), so the problem will eventually go away, but it is still an issue in this version of rust (`1.88.0`). See also rust-lang/rust-clippy#15151 3. Explicitly ignored [result_large_err](https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err) warnings - I'll leave it up to the code owners whether/how to fix the warnings 4. Modified the backtrace message in `rs/execution_environment/tests/backtraces.rs` 5. Bumped max compressed wasm size of some nns canisters from 1.5MB to 1.6MB in `file_size_check` tests 6. Fixed [io_other_error](https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error) warnings 7. Fixed [iter_kv_map](https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map) warnings 8. Fixed [manual_contains](https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains) warnings 9. Fixed some other, rarely occurring, clippy warnings ## Benchmarks updates ### //rs/ledger_suite/icrc1/ledger:canbench_u256 Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|-------------------------------------|-------|---------|---------|-----|--------|-----|---------| | + | bench_icrc1_transfers::post_upgrade | 1 | 365.33M | +3.75% | 71 | 0.00% | 0 | 0.00% | | + | bench_icrc1_transfers::upgrade | 1 | 516.12M | +3.17% | 200 | 0.00% | 128 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change ### //rs/ledger_suite/icrc1/ledger:canbench_u64 Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|--------------------------------------------|-------|--------|---------|----|---------|-----|---------| | + | bench_icrc1_transfers::icrc2_approve | 1 | 18.44B | -0.22% | 29 | +16.00% | 128 | 0.00% | | - | bench_icrc1_transfers::icrc1_transfer | 1 | 12.24B | -0.50% | 31 | -8.82% | 0 | 0.00% | | - | bench_icrc1_transfers::icrc2_transfer_from | 1 | 20.57B | -0.54% | 3 | -25.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change ### //rs/nns/governance:governance-canbench Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|-----------------------------------|-------|--------|---------|----|--------|-----|---------| | + | add_neuron_inactive_maximum | | 64.86M | +5.79% | 0 | 0.00% | 0 | 0.00% | | + | add_neuron_active_maximum_stable | | 64.86M | +5.79% | 0 | 0.00% | 0 | 0.00% | | - | list_neurons_stable | | 63.04M | -5.65% | 9 | 0.00% | 0 | 0.00% | | - | list_neurons_by_subaccount_stable | | 62.12M | -5.67% | 5 | 0.00% | 0 | 0.00% | | - | range_neurons_performance | | 51.56M | -6.28% | 0 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change --------- Co-authored-by: IDX GitHub Automation <> Co-authored-by: IDX GitHub Automation <[email protected]>
1 parent 040a532 commit a4c1c9b

File tree

106 files changed

+275
-280
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

106 files changed

+275
-280
lines changed

‎.devcontainer/devcontainer.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"image": "ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34",
2+
"image": "ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c",
33
"remoteUser": "ubuntu",
44
"privileged": true,
55
"runArgs": [

‎.github/workflows-source/ci-main.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ env:
3434

3535
anchors:
3636
image: &image
37-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
37+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
3838
dind-large-setup: &dind-large-setup
3939
runs-on:
4040
labels: dind-large

‎.github/workflows-source/ci-pr-only.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ env:
1717

1818
anchors:
1919
image: &image
20-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
20+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
2121
container: &container
2222
container:
2323
<<: *image

‎.github/workflows-source/release-testing.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ env:
2525

2626
anchors:
2727
image: &image
28-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
28+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
2929
dind-large-setup: &dind-large-setup
3030
runs-on:
3131
labels: dind-large

‎.github/workflows-source/schedule-daily.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ env:
1414

1515
anchors:
1616
image: &image
17-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
17+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
1818

1919
backup-pod-access: &backup-pod-access
2020
run: |

‎.github/workflows/ci-main.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ jobs:
109109
runs-on:
110110
labels: dind-large
111111
container:
112-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
112+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
113113
options: >-
114114
-e NODE_NAME --privileged --cgroupns host
115115
timeout-minutes: 120
@@ -298,7 +298,7 @@ jobs:
298298
runs-on:
299299
labels: dind-large
300300
container:
301-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
301+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
302302
options: >-
303303
-e NODE_NAME --privileged --cgroupns host
304304
timeout-minutes: 90
@@ -342,7 +342,7 @@ jobs:
342342
runs-on:
343343
labels: dind-large
344344
container:
345-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
345+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
346346
options: >-
347347
-e NODE_NAME --privileged --cgroupns host
348348
timeout-minutes: 90
@@ -364,7 +364,7 @@ jobs:
364364
runs-on:
365365
labels: dind-small
366366
container:
367-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
367+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
368368
options: >-
369369
-e NODE_NAME
370370
timeout-minutes: 30
@@ -396,7 +396,7 @@ jobs:
396396
needs: [config]
397397
name: Build IC
398398
container:
399-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
399+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
400400
options: >-
401401
-e NODE_NAME --privileged --cgroupns host
402402
timeout-minutes: 90
@@ -478,7 +478,7 @@ jobs:
478478
runs-on:
479479
labels: dind-large
480480
container:
481-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
481+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
482482
options: >-
483483
-e NODE_NAME --privileged --cgroupns host
484484
timeout-minutes: 90
@@ -497,7 +497,7 @@ jobs:
497497
runs-on:
498498
labels: dind-small
499499
container:
500-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
500+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
501501
options: >-
502502
-e NODE_NAME
503503
timeout-minutes: 30
@@ -534,7 +534,7 @@ jobs:
534534
runs-on:
535535
labels: dind-small
536536
container:
537-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
537+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
538538
options: >-
539539
-e NODE_NAME
540540
timeout-minutes: 30

‎.github/workflows/ci-pr-only.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
runs-on:
2121
labels: dind-small
2222
container:
23-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
23+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
2424
options: >-
2525
-e NODE_NAME
2626
if: ${{ github.event_name != 'merge_group' }}
@@ -38,7 +38,7 @@ jobs:
3838
runs-on:
3939
labels: dind-large
4040
container:
41-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
41+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
4242
options: >-
4343
-e NODE_NAME
4444
if: ${{ github.event_name != 'merge_group' }}
@@ -68,7 +68,7 @@ jobs:
6868
runs-on:
6969
labels: dind-small
7070
container:
71-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
71+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
7272
options: >-
7373
-e NODE_NAME
7474
if: ${{ github.event_name != 'merge_group' }}
@@ -110,7 +110,7 @@ jobs:
110110
runs-on:
111111
labels: dind-small
112112
container:
113-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
113+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
114114
options: >-
115115
-e NODE_NAME
116116
timeout-minutes: 5
@@ -146,7 +146,7 @@ jobs:
146146
runs-on:
147147
labels: dind-small
148148
container:
149-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
149+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
150150
options: >-
151151
-e NODE_NAME
152152
if: ${{ github.event_name != 'merge_group' }}
@@ -207,7 +207,7 @@ jobs:
207207
runs-on:
208208
labels: dind-large
209209
container:
210-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
210+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
211211
options: >-
212212
-e NODE_NAME
213213
if: contains(github.event.pull_request.labels.*.name, 'CI_COVERAGE')

‎.github/workflows/pocket-ic-tests-windows.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
bazel-build-pocket-ic:
1818
name: Bazel Build PocketIC
1919
container:
20-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
20+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
2121
options: >-
2222
-e NODE_NAME --privileged --cgroupns host
2323
timeout-minutes: 90
@@ -61,7 +61,7 @@ jobs:
6161
fetch-depth: ${{ github.event_name == 'pull_request' && 256 || 0 }}
6262
- name: Linting
6363
run: |
64-
cargo clippy -p pocket-ic --locked --all-features --all-targets -- -D warnings -D clippy::all -D clippy::mem_forget -C debug-assertions=off
64+
cargo clippy -p pocket-ic --locked --all-features --all-targets -- -D warnings -D clippy::all -D clippy::mem_forget -C debug-assertions=off -A clippy::uninlined_format_args
6565
6666
pocket-ic-tests-on-windows:
6767
name: PocketIC Tests on Windows

‎.github/workflows/rate-limits-backend-release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
labels: dind-large
3333

3434
container:
35-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
35+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
3636
options: >-
3737
-e NODE_NAME --privileged --cgroupns host -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
3838

‎.github/workflows/release-testing.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
runs-on:
3232
labels: dind-large
3333
container:
34-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
34+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
3535
options: >-
3636
-e NODE_NAME --privileged --cgroupns host
3737
timeout-minutes: 180 # 3 hours
@@ -56,7 +56,7 @@ jobs:
5656
runs-on:
5757
labels: dind-large
5858
container:
59-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
59+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
6060
options: >-
6161
-e NODE_NAME --privileged --cgroupns host
6262
timeout-minutes: 60
@@ -97,7 +97,7 @@ jobs:
9797
runs-on:
9898
labels: dind-large
9999
container:
100-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
100+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
101101
options: >-
102102
-e NODE_NAME --privileged --cgroupns host
103103
timeout-minutes: 180 # 3 hours
@@ -124,7 +124,7 @@ jobs:
124124
runs-on:
125125
labels: dind-large
126126
container:
127-
image: ghcr.io/dfinity/ic-build@sha256:d8f7308e97e095a9c9b0cdb1b6f260f459424e3792ebd49bb7c6ff6098941a34
127+
image: ghcr.io/dfinity/ic-build@sha256:a5edec0ae2b045ef86bc957f9a3155a360edc2a273a700eabd0670dc489d809c
128128
options: >-
129129
-e NODE_NAME --privileged --cgroupns host
130130
timeout-minutes: 180 # 3 hours

0 commit comments

Comments
 (0)