Skip to content

Commit d056c67

Browse files
committed
Merge branch 'mraszyk/httpbin-connection-close' into 'master'
Reducing test flakiness: add Connection: close header to httpbin server The header `Connection: close` is supposed to prevent the client (https outcalls adapter in this case) from keeping idle connections alive as they're not being kept alive on the httpbin server. This is supposed to **reduce** system test **flakiness** due to reusing connections believed to be alive by the replica that are already closed on the httpbin server. See merge request dfinity-lab/public/ic!12497
2 parents a3bddda + 7bfc18e commit d056c67

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

WORKSPACE.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -437,8 +437,8 @@ http_archive(
437437
package(default_visibility = ["//visibility:public"])
438438
filegroup(name = "artifacts", srcs = glob(["build/*", "test-data/*"]), visibility = ["//visibility:public"])
439439
""",
440-
sha256 = "f91fed3158779b32310e5cf7bcdf7915b38eaf635a72a52c844f656806e3e5d6",
441-
urls = ["https://download.dfinity.systems/ic-ref/ic-ref-test-0.0.1-5fc27bdc-x86_64-linux.tar.gz"],
440+
sha256 = "6ae6664fc6f5879b7ca9f7a1f3262c9a2d6f0118238759d222049a29b4c523b4",
441+
urls = ["https://download.dfinity.systems/ic-ref/ic-ref-test-0.0.1-a1b3f670-x86_64-linux.tar.gz"],
442442
)
443443

444444
# Deployed NNS canisters

rs/tests/httpbin-rs/src/main.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ impl Response {
6767
));
6868
}
6969
fn set_aux_headers(&mut self) {
70+
self.headers
71+
.push(("Connection".to_string(), "close".to_string()));
7072
self.headers
7173
.push(("Access-Control-Allow-Origin".to_string(), "*".to_string()));
7274
self.headers.push((

0 commit comments

Comments
 (0)