Skip to content

Commit f206122

Browse files
committed
Merge branch 'mathias-CRP-2058-increase-min-subnet-size-in-flaky-test' into 'master'
test(crypto): CRP-2058: Increase min subnet size in flaky test The `create_transcript::should_fail_create_transcript_with_disallowed_dealer` test was flaky since it generated a subnet of size `(1..10)`, then removes a dealer, and then creates `IDkgTranscriptParams` with the rest of the nodes in the subnet as dealers. If the initial subnet size was 1, then `IDkgTranscriptParams` will be generated with a BTreeSet of size 0, which panics. This MR increases the minimum subnet size to 2. See merge request dfinity-lab/public/ic!12485
2 parents 2562504 + 325dedc commit f206122

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rs/crypto/tests/canister_threshold_sigs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ mod create_transcript {
189189

190190
#[test]
191191
fn should_fail_create_transcript_with_disallowed_dealer() {
192-
let subnet_size = thread_rng().gen_range(1..10);
192+
let subnet_size = thread_rng().gen_range(2..10);
193193
let env = CanisterThresholdSigTestEnvironment::new(subnet_size);
194194
let params = env.params_for_random_sharing(AlgorithmId::ThresholdEcdsaSecp256k1);
195195
let signed_dealings = create_and_verify_signed_dealings(&params, &env.crypto_components);

0 commit comments

Comments
 (0)