chore(backend): remove get_proposal_payload canister endpoint (#7752)

# Motivation

The frontend no longer calls `get_proposal_payload` after switching to
`selfDescribingAction` in #7742. This is the first step toward removing
the `proposals` crate entirely.

# Changes

- Removed the `get_proposal_payload` update endpoint from the backend
canister.
- Removed the `proposals` crate dependency from the backend
`Cargo.toml`.
- Removed `GetProposalPayloadResponse` type and `get_proposal_payload`
method from the Candid interface (backend and frontend copies).
- Removed the `get_proposal_payload` entry from canister export lists
(production and test).
- Removed the `test-proposal-payload` script and its CI step in the
build workflow.

Author: yhabib

.github/workflows/build.yml

@@ -213,8 +213,6 @@ jobs:
           pushd snsdemo
           bin/dfx-sns-demo-install
           popd
-      - name: Test getting proposal payloads
-        run: scripts/nns-dapp/test-proposal-payload
       - name: Install tools
         run: |
           # libarchive-zip-perl is needed for crc32, used by test-cmc-notify.

Cargo.lock

@@ -69,10 +69,6 @@ export const idlFactory = ({ IDL }) => {
   });
   const BlockHeight = IDL.Nat64;
   const NeuronId = IDL.Nat64;
-  const GetProposalPayloadResponse = IDL.Variant({
-    Ok: IDL.Text,
-    Err: IDL.Text,
-  });
   const Stats = IDL.Record({
     seconds_since_last_ledger_sync: IDL.Nat64,
     sub_accounts_count: IDL.Nat64,
@@ -185,11 +181,6 @@ export const idlFactory = ({ IDL }) => {
     get_canisters: IDL.Func([], [IDL.Vec(CanisterDetails)], []),
     get_fav_projects: IDL.Func([], [GetFavProjectsResponse], []),
     get_imported_tokens: IDL.Func([], [GetImportedTokensResponse], []),
-    get_proposal_payload: IDL.Func(
-      [IDL.Nat64],
-      [GetProposalPayloadResponse],
-      []
-    ),
     get_stats: IDL.Func([], [Stats], []),
     http_request: IDL.Func([HttpRequest], [HttpResponse], []),
     register_hardware_wallet: IDL.Func(

frontend/src/lib/canisters/nns-dapp/nns-dapp.certified.idl.js

@@ -123,12 +123,6 @@ type DetachCanisterResponse =
         CanisterNotFound;
     };
 
-type GetProposalPayloadResponse =
-    variant {
-        Ok: text;
-        Err: text;
-    };
-
 type Stats =
     record {
         accounts_count: nat64;
@@ -194,7 +188,6 @@ service : {
     detach_canister: (DetachCanisterRequest) -> (DetachCanisterResponse);
     set_imported_tokens: (ImportedTokens) -> (SetImportedTokensResponse);
     get_imported_tokens: () -> (GetImportedTokensResponse) query;
-    get_proposal_payload: (nat64) -> (GetProposalPayloadResponse);
     get_stats: () -> (Stats) query;
 
     http_request: (request: HttpRequest) -> (HttpResponse) query;

frontend/src/lib/canisters/nns-dapp/nns-dapp.did

@@ -69,10 +69,6 @@ export const idlFactory = ({ IDL }) => {
   });
   const BlockHeight = IDL.Nat64;
   const NeuronId = IDL.Nat64;
-  const GetProposalPayloadResponse = IDL.Variant({
-    Ok: IDL.Text,
-    Err: IDL.Text,
-  });
   const Stats = IDL.Record({
     seconds_since_last_ledger_sync: IDL.Nat64,
     sub_accounts_count: IDL.Nat64,
@@ -185,11 +181,6 @@ export const idlFactory = ({ IDL }) => {
     get_canisters: IDL.Func([], [IDL.Vec(CanisterDetails)], ["query"]),
     get_fav_projects: IDL.Func([], [GetFavProjectsResponse], ["query"]),
     get_imported_tokens: IDL.Func([], [GetImportedTokensResponse], ["query"]),
-    get_proposal_payload: IDL.Func(
-      [IDL.Nat64],
-      [GetProposalPayloadResponse],
-      []
-    ),
     get_stats: IDL.Func([], [Stats], ["query"]),
     http_request: IDL.Func([HttpRequest], [HttpResponse], ["query"]),
     register_hardware_wallet: IDL.Func(

frontend/src/lib/canisters/nns-dapp/nns-dapp.idl.js

@@ -44,7 +44,6 @@ export type GetFavProjectsResponse =
 export type GetImportedTokensResponse =
   | { Ok: ImportedTokens }
   | { AccountNotFound: null };
-export type GetProposalPayloadResponse = { Ok: string } | { Err: string };
 export interface HardwareWalletAccountDetails {
   principal: Principal;
   name: string;
@@ -173,7 +172,6 @@ export default interface _SERVICE {
   get_imported_tokens: () => Promise<GetImportedTokensResponse>;
   get_fav_projects: () => Promise<GetFavProjectsResponse>;
   get_address_book: () => Promise<GetAddressBookResponse>;
-  get_proposal_payload: (arg_0: bigint) => Promise<GetProposalPayloadResponse>;
   get_stats: () => Promise<Stats>;
   http_request: (arg_0: HttpRequest) => Promise<HttpResponse>;
   register_hardware_wallet: (

frontend/src/lib/canisters/nns-dapp/nns-dapp.types.ts

@@ -39,8 +39,6 @@ icp-ledger = { workspace = true }
 icrc-ledger-types = { workspace = true }
 on_wire = { workspace = true }
 
-proposals = { path = "../proposals" }
-
 [dev-dependencies]
 anyhow = "1.0.95"
 candid_parser = "0.1.2"

rs/backend/Cargo.toml

@@ -18,7 +18,6 @@ canister_update add_stable_asset
 canister_update attach_canister
 canister_update create_sub_account
 canister_update detach_canister
-canister_update get_proposal_payload
 canister_update register_hardware_wallet
 canister_update rename_canister
 canister_update rename_sub_account

rs/backend/nns-dapp-exports-production.txt

@@ -20,7 +20,6 @@ canister_update attach_canister
 canister_update create_sub_account
 canister_update create_toy_accounts
 canister_update detach_canister
-canister_update get_proposal_payload
 canister_update register_hardware_wallet
 canister_update rename_canister
 canister_update rename_sub_account

rs/backend/nns-dapp-exports-test.txt

@@ -125,12 +125,6 @@ type DetachCanisterResponse =
         AccountNotFound;
     };
 
-type GetProposalPayloadResponse =
-    variant {
-        Ok: text;
-        Err: text;
-    };
-
 type Stats =
     record {
         accounts_count: nat64;
@@ -292,7 +286,6 @@ service: (opt Config) -> {
     get_fav_projects: () -> (GetFavProjectsResponse) query;
     set_address_book: (AddressBook) -> (SetAddressBookResponse);
     get_address_book: () -> (GetAddressBookResponse) query;
-    get_proposal_payload: (nat64) -> (GetProposalPayloadResponse);
     get_stats: () -> (Stats) query;
     get_histogram: () -> (Histogram) query;
     get_tvl : () -> (TvlResponse) query;