tests

Author: yhabib

frontend/src/tests/lib/modals/accounts/IcrcTokenTransactionModal.spec.ts

@@ -14,6 +14,7 @@ import { renderModal } from "$tests/mocks/modal.mock";
 import { principal } from "$tests/mocks/sns-projects.mock";
 import { IcrcTokenTransactionModalPo } from "$tests/page-objects/IcrcTokenTransactionModal.page-object";
 import { JestPageObjectElement } from "$tests/page-objects/jest.page-object";
+import { runResolvedPromises } from "$tests/utils/timers.test-utils";
 import { TokenAmountV2 } from "@dfinity/utils";
 import { encodeIcrcAccount } from "@icp-sdk/canisters/ledger/icrc";
 
@@ -26,6 +27,8 @@ describe("IcrcTokenTransactionModal", () => {
     amount: token.fee,
     token,
   });
+  const mintingAccount = { owner: principal(99) };
+  const mintingAccountAddress = encodeIcrcAccount(mintingAccount);
 
   beforeEach(() => {
     resetIdentity();
@@ -34,8 +37,19 @@ describe("IcrcTokenTransactionModal", () => {
       routeId: AppPath.Accounts,
     });
     vi.spyOn(ledgerApi, "icrcTransfer").mockResolvedValue(1234n);
+    vi.spyOn(ledgerApi, "queryIcrcMintingAccount").mockResolvedValue(undefined);
   });
 
+  const setupAccount = () => {
+    icrcAccountsStore.set({
+      ledgerCanisterId,
+      accounts: {
+        accounts: [{ ...mockIcrcMainAccount, balanceUlps: 1000n * 10n ** 18n }],
+        certified: true,
+      },
+    });
+  };
+
   const renderModalComponent = async () => {
     const { container } = await renderModal({
       component: IcrcTokenTransactionModal,
@@ -47,6 +61,8 @@ describe("IcrcTokenTransactionModal", () => {
       },
     });
 
+    await runResolvedPromises();
+
     return IcrcTokenTransactionModalPo.under(
       new JestPageObjectElement(container)
     );
@@ -59,25 +75,11 @@ describe("IcrcTokenTransactionModal", () => {
   });
 
   it("should transfer tokens", async () => {
-    // Used to choose the source account
-    icrcAccountsStore.set({
-      ledgerCanisterId,
-      accounts: {
-        accounts: [
-          {
-            ...mockIcrcMainAccount,
-            balanceUlps: 1000n * 10n ** 18n,
-          },
-        ],
-        certified: true,
-      },
-    });
+    setupAccount();
 
     const po = await renderModalComponent();
 
-    const toAccount = {
-      owner: principal(2),
-    };
+    const toAccount = { owner: principal(2) };
     const amount = 10;
 
     await po.transferToAddress({
@@ -94,4 +96,78 @@ describe("IcrcTokenTransactionModal", () => {
       fee: token.fee,
     });
   });
+
+  describe("burn address", () => {
+    beforeEach(() => {
+      vi.spyOn(ledgerApi, "queryIcrcMintingAccount").mockResolvedValue(
+        mintingAccount
+      );
+    });
+
+    it("should show burn address label when destination is the minting account", async () => {
+      setupAccount();
+      const po = await renderModalComponent();
+      const formPo = po.getTransactionFormPo();
+
+      expect(await formPo.hasBurnAddressLabel()).toBe(false);
+
+      await formPo.enterAddress(mintingAccountAddress);
+
+      expect(await formPo.hasBurnAddressLabel()).toBe(true);
+    });
+
+    it("should not show burn address label for a regular address", async () => {
+      setupAccount();
+      const po = await renderModalComponent();
+      const formPo = po.getTransactionFormPo();
+
+      await formPo.enterAddress(encodeIcrcAccount({ owner: principal(2) }));
+
+      expect(await formPo.hasBurnAddressLabel()).toBe(false);
+    });
+
+    it("should hide the fee when destination is the minting account", async () => {
+      setupAccount();
+      const po = await renderModalComponent();
+      const formPo = po.getTransactionFormPo();
+
+      expect(await formPo.hasFee()).toBe(true);
+
+      await formPo.enterAddress(mintingAccountAddress);
+
+      expect(await formPo.hasFee()).toBe(false);
+    });
+
+    it("should transfer with fee 0 when destination is the minting account", async () => {
+      setupAccount();
+      const po = await renderModalComponent();
+
+      await po.transferToAddress({
+        destinationAddress: mintingAccountAddress,
+        amount: 1,
+      });
+
+      expect(ledgerApi.icrcTransfer).toHaveBeenCalledTimes(1);
+      expect(ledgerApi.icrcTransfer).toHaveBeenCalledWith(
+        expect.objectContaining({
+          fee: 0n,
+          to: mintingAccount,
+        })
+      );
+    });
+
+    it("should transfer with normal fee for a regular address", async () => {
+      setupAccount();
+      const po = await renderModalComponent();
+
+      await po.transferToAddress({
+        destinationAddress: encodeIcrcAccount({ owner: principal(2) }),
+        amount: 1,
+      });
+
+      expect(ledgerApi.icrcTransfer).toHaveBeenCalledWith(
+        expect.objectContaining({ fee: token.fee })
+      );
+    });
+  });
 });

frontend/src/tests/lib/pages/SnsWallet.spec.ts

@@ -78,6 +78,9 @@ describe("SnsWallet", () => {
       balance: 0n,
     });
     vi.spyOn(icrcLedgerApi, "icrcTransfer").mockResolvedValue(10n);
+    vi.spyOn(icrcLedgerApi, "queryIcrcMintingAccount").mockResolvedValue(
+      undefined
+    );
     vi.spyOn(
       workerTransactionsServices,
       "initTransactionsWorker"

frontend/src/tests/page-objects/TransactionForm.page-object.ts

@@ -151,4 +151,12 @@ export class TransactionFormPo extends BasePageObject {
   async hasManualAddressLink(): Promise<boolean> {
     return this.getManualAddressLink().isPresent();
   }
+
+  hasBurnAddressLabel(): Promise<boolean> {
+    return this.root.byTestId("burn-address-label").isPresent();
+  }
+
+  async hasFee(): Promise<boolean> {
+    return this.getTransactionFormFeePo().isPresent();
+  }
 }