FIXME comment

vporton · vporton · commit 368e687d6b74 · 2024-04-14T15:29:40.000+03:00
diff --git a/src/dfx/src/lib/models/canister.rs b/src/dfx/src/lib/models/canister.rs
@@ -550,6 +550,7 @@ impl CanisterPool {
         }
 
         // Traverse the graph of dependencies starting from `real_canisters_to_build` set.
+        // FIXME: This hangs if circular dependencies (see below).
         let mut current_canisters_to_build =
             HashMap::from_iter(real_canisters_to_build.iter().map(|c| (c.canister_id(), ())));
         loop {

Original file line number	Diff line number	Diff line change
`@@ -550,6 +550,7 @@ impl CanisterPool {`
`550`	`550`	`}`
`551`	`551`
`552`	`552`	// Traverse the graph of dependencies starting from `real_canisters_to_build` set.
	`553`	`+ // FIXME: This hangs if circular dependencies (see below).`
`553`	`554`	`let mut current_canisters_to_build =`
`554`	`555`	`HashMap::from_iter(real_canisters_to_build.iter().map(\|c\| (c.canister_id(), ())));`
`555`	`556`	`loop {`