Skip to content

Commit 8045b53

Browse files
committed
comments
1 parent 79faa77 commit 8045b53

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/dfx/src/lib/models/canister.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -559,19 +559,15 @@ impl CanisterPool {
559559
#[context("Failed to build dependencies graph for canister pool.")]
560560
fn build_dependencies_graph(&self, _canisters_to_build: Option<Vec<String>>) -> DfxResult<DiGraph<CanisterId, ()>> {
561561
for canister in &self.canisters { // a little inefficient
562-
// if !current_canisters_to_build.contains_key(&canister.canister_id()) {
563-
// continue;
564-
// }
565562
let canister_info = &canister.info;
566563
// FIXME: Is `unwrap()` in the next operator correct?
567-
// TODO: Ignored return value is a hack
564+
// TODO: Ignored return value is a hack.
568565
let _deps: Vec<CanisterId> = canister.builder.get_dependencies(self, canister_info)?
569566
.into_iter().filter(|d| *d != canister_info.get_canister_id().unwrap()).collect(); // TODO: This is a hack.
570567
}
571568

572569
Ok(self.imports.borrow().graph.filter_map(
573570
|_node_index, node_weight| {
574-
// B::from(node_weight)
575571
match node_weight {
576572
// TODO: `get_first_canister_with_name` is a hack
577573
MotokoImport::Canister(name) => Some(self.get_first_canister_with_name(&name).unwrap().canister_id()),

0 commit comments

Comments
 (0)