[MRG] Merge pull request #685 from dfir-iris/ruff

Ruff

Author: whikernel

.github/workflows/ci.yml

@@ -27,6 +27,11 @@ jobs:
     steps:
       - name: Check out iris
         uses: actions/checkout@v4
+      - name: Check code with ruff
+        uses: astral-sh/ruff-action@v2
+        with:
+          args: check --output-format=github
+          src: ./source
       - name: Build dockers
         run: |
           # TODO using the environment file from tests to build here. 

pyproject.toml

@@ -0,0 +1,3 @@
+[tool.ruff.lint]
+ignore = ["E402", "E711", "E712", "E721", "E722", "F821", "F841", "F541", "F403", "F401"]
+

source/app/alembic/versions/4ecdfcb34f7c_add_compromise_status_to_assets.py

@@ -10,7 +10,7 @@
 
 # revision identifiers, used by Alembic.
 from app.alembic.alembic_utils import _table_has_column
-from app.models import CompromiseStatus
+from app.models.models import CompromiseStatus
 
 revision = '4ecdfcb34f7c'
 down_revision = 'a929ef458490'

source/app/blueprints/access_controls.py

@@ -48,7 +48,7 @@
 from app.iris_engine.access_control.utils import ac_fast_check_user_has_case_access
 from app.iris_engine.access_control.utils import ac_get_effective_permissions_of_user
 from app.iris_engine.utils.tracker import track_activity
-from app.models import Cases
+from app.models.cases import Cases
 from app.models.authorization import Permissions
 from app.models.authorization import CaseAccessLevel
 

source/app/blueprints/rest/dim_tasks_routes.py

@@ -30,8 +30,8 @@
 from app.models import CaseAssets
 from app.models import CaseReceivedFile
 from app.models import CaseTasks
-from app.models import Cases
-from app.models import CasesEvent
+from app.models.cases import Cases
+from app.models.cases import CasesEvent
 from app.models import GlobalTasks
 from app.models import Ioc
 from app.models import Notes

source/app/business/auth.py

@@ -9,7 +9,7 @@
 from app.iris_engine.access_control.ldap_handler import ldap_authenticate
 from app.iris_engine.access_control.utils import ac_get_effective_permissions_of_user
 from app.iris_engine.utils.tracker import track_activity
-from app.models import Cases
+from app.models.cases import Cases
 from app.schema.marshables import UserSchema
 
 log = app.logger

source/app/datamgmt/activities/activities_db.py

@@ -19,7 +19,7 @@
 from sqlalchemy import and_
 from sqlalchemy import desc
 
-from app.models import Cases
+from app.models.cases import Cases
 from app.models.authorization import User
 from app.models.models import UserActivity
 

source/app/datamgmt/alerts/alerts_db.py

@@ -37,8 +37,16 @@
 from app.datamgmt.states import update_timeline_state
 from app.iris_engine.access_control.utils import ac_current_user_has_permission
 from app.iris_engine.utils.common import parse_bf_date_format
-from app.models import Cases, EventCategory, Tags, AssetsType, Comments, CaseAssets, alert_assets_association, \
-    alert_iocs_association, Ioc, Client
+from app.models.cases import Cases
+from app.models import EventCategory
+from app.models import Tags
+from app.models import AssetsType
+from app.models import Comments
+from app.models import CaseAssets
+from app.models import alert_assets_association
+from app.models import alert_iocs_association
+from app.models import Ioc
+from app.models import Client
 from app.models.alerts import Alert, AlertStatus, AlertCaseAssociation, SimilarAlertsCache, AlertResolutionStatus, \
     AlertSimilarity, Severity
 from app.models.authorization import Permissions, User

source/app/datamgmt/case/case_assets_db.py

@@ -29,7 +29,7 @@
 from app.models import AssetsType
 from app.models import CaseAssets
 from app.models import CaseEventsAssets
-from app.models import Cases
+from app.models.cases import Cases
 from app.models import Comments
 from app.models import CompromiseStatus
 from app.models import Ioc

source/app/datamgmt/case/case_events_db.py

@@ -25,7 +25,7 @@
 from app.models import CaseEventCategory
 from app.models import CaseEventsAssets
 from app.models import CaseEventsIoc
-from app.models import CasesEvent
+from app.models.cases import CasesEvent
 from app.models import Comments
 from app.models import EventCategory
 from app.models import EventComments