Skip to content

Commit 22e0496

Browse files
committed
Code cleanup
1 parent e589c16 commit 22e0496

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

source/app/business/alerts.py

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,18 @@ def _create_asset_node(asset_id, asset_info, in_dark_mode):
188188
}
189189

190190

191+
def _create_case_node(case_id, description, close_date, in_dark_mode):
192+
return {
193+
'id': f'case_{case_id}',
194+
'label': f'[Closed] Case #{case_id}' if close_date else f'Case #{case_id}',
195+
'title': description,
196+
'group': 'case',
197+
'shape': 'icon',
198+
'icon': _get_icon_case(close_date),
199+
'font': _get_font(in_dark_mode)
200+
}
201+
202+
191203
def _build_related_alerts_graph(alerts_dict, open_cases, closed_cases, customer_id, in_dark_mode):
192204
nodes = []
193205
edges = []
@@ -242,27 +254,21 @@ def _build_related_alerts_graph(alerts_dict, open_cases, closed_cases, customer_
242254

243255
added_cases = set()
244256
for case_id in cases_data:
257+
case_data = cases_data[case_id]
245258
if case_id not in added_cases:
246-
is_closed = cases_data[case_id].get('close_date')
247-
nodes.append({
248-
'id': f'case_{case_id}',
249-
'label': f'[Closed] Case #{case_id}' if cases_data[case_id].get('close_date') else f'Case #{case_id}',
250-
'title': cases_data[case_id].get("description"),
251-
'group': 'case',
252-
'shape': 'icon',
253-
'icon': _get_icon_case(is_closed),
254-
'font': _get_font(in_dark_mode)
255-
})
259+
close_date = case_data.get('close_date')
260+
description = case_data.get('description')
261+
nodes.append(_create_case_node(case_id, description, close_date, in_dark_mode))
256262
added_cases.add(case_id)
257263

258-
for ioc_value in cases_data[case_id]['matching_ioc']:
264+
for ioc_value in case_data['matching_ioc']:
259265
edges.append({
260266
'from': f'ioc_{ioc_value}',
261267
'to': f'case_{case_id}',
262268
'dashes': True
263269
})
264270

265-
for asset_name in cases_data[case_id]['matching_assets']:
271+
for asset_name in case_data['matching_assets']:
266272
edges.append({
267273
'from': f'asset_{asset_name}',
268274
'to': f'case_{case_id}',

0 commit comments

Comments
 (0)