Skip to content

Commit 3fb2b4e

Browse files
committed
Build the ui before API tests, rather than just creating the necessary directory
1 parent 91af0dd commit 3fb2b4e

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,15 +163,21 @@ jobs:
163163
docker load --input ${{ runner.temp }}/iriswebapp_app.tar
164164
- name: Check out iris
165165
uses: actions/checkout@v4
166+
- uses: actions/setup-node@v4
167+
with:
168+
node-version: 20
169+
cache: npm
170+
cache-dependency-path: ui/package-lock.json
171+
- name: Build ui to be mounted in development docker
172+
working-directory: ui
173+
run: |
174+
npm ci
175+
npm run build
166176
- name: Start development server
167177
run: |
168178
# Even though, we use --env-file option when running docker compose, this is still necessary, because the compose has a env_file attribute :(
169179
# TODO should move basic.env file, which is in directory tests, up. It's used in several places. Maybe, rename it into dev.env
170180
cp tests/data/basic.env .env
171-
# This is needed to have the path where icons are store when the volumes are mounted in the docker-compose
172-
# It will map to /iriswebapp/static/assets/img/graph/
173-
# Could alternatively build the full ui to be mounted in the development server. Maybe will rather do that in the future
174-
mkdir -p ui/dist/assets/img/graph/
175181
docker compose --file docker-compose.dev.yml up --detach
176182
- name: Run tests
177183
working-directory: tests

0 commit comments

Comments
 (0)