[FIX] GET /api/v2/cases/{case_identifier}/tasks/{task_identifier} should return 200 (rather than 201)

Author: c8y3

source/app/blueprints/rest/v2/cases/tasks.py

@@ -19,13 +19,19 @@
 from flask import Blueprint
 from flask import request
 
-from app.blueprints.rest.endpoints import response_api_error, response_api_not_found, response_api_deleted
+from app.blueprints.rest.endpoints import response_api_error
+from app.blueprints.rest.endpoints import response_api_not_found
+from app.blueprints.rest.endpoints import response_api_deleted
+from app.blueprints.rest.endpoints import response_api_success
 from app.blueprints.rest.endpoints import response_api_created
 from app.blueprints.access_controls import ac_api_return_access_denied
 from app.blueprints.access_controls import ac_api_requires
 from app.schema.marshables import CaseTaskSchema
-from app.business.errors import BusinessProcessingError, ObjectNotFoundError
-from app.business.tasks import tasks_create, tasks_get, tasks_delete
+from app.business.errors import BusinessProcessingError
+from app.business.errors import ObjectNotFoundError
+from app.business.tasks import tasks_create
+from app.business.tasks import tasks_get
+from app.business.tasks import tasks_delete
 from app.models.authorization import CaseAccessLevel
 from app.iris_engine.access_control.utils import ac_fast_check_current_user_has_case_access
 
@@ -74,7 +80,7 @@ def get_case_task(case_id, identifier):
             return ac_api_return_access_denied(caseid=task.task_case_id)
 
         task_schema = CaseTaskSchema()
-        return response_api_created(task_schema.dump(task))
+        return response_api_success(task_schema.dump(task))
     except ObjectNotFoundError:
         return response_api_not_found()
 

source/app/blueprints/rest/v2/tasks.py

@@ -19,7 +19,7 @@
 from flask import Blueprint
 
 from app.blueprints.rest.endpoints import response_api_not_found
-from app.blueprints.rest.endpoints import response_api_created
+from app.blueprints.rest.endpoints import response_api_success
 from app.blueprints.rest.endpoints import response_api_deleted
 from app.blueprints.rest.endpoints import response_api_error
 from app.blueprints.access_controls import ac_api_requires
@@ -49,8 +49,7 @@ def get_case_task(identifier):
             return ac_api_return_access_denied(caseid=task.task_case_id)
 
         task_schema = CaseTaskSchema()
-        # TODO should be response_api_success => add a test
-        return response_api_created(task_schema.dump(task))
+        return response_api_success(task_schema.dump(task))
     except ObjectNotFoundError:
         return response_api_not_found()
 

tests/tests_rest_tasks.py

@@ -51,15 +51,15 @@ def test_create_case_with_spurious_slash_should_return_404(self):
         response = self._subject.create(f'/api/v2/cases/{case_identifier}/tasks/', body)
         self.assertEqual(404, response.status_code)
 
-    def test_get_task_should_return_201(self):
+    def test_get_task_should_return_200(self):
         case_identifier = self._subject.create_dummy_case()
         body = {'task_assignees_id': [2], 'task_description': '', 'task_status_id': 1, 'task_tags': '',
                 'task_title': 'dummy title',
                 'custom_attributes': {}}
         response = self._subject.create(f'/api/v2/cases/{case_identifier}/tasks', body).json()
         task_identifier = response['id']
         response = self._subject.get(f'/api/v2/cases/{case_identifier}/tasks/{task_identifier}')
-        self.assertEqual(201, response.status_code)
+        self.assertEqual(200, response.status_code)
 
     def test_get_task_with_missing_task_identifier_should_return_error(self):
         case_identifier = self._subject.create_dummy_case()