Merge pull request #961 from dfir-iris/api_v2_put_customer

Api v2 update customer

Author: whikernel

.github/workflows/ci.yml

@@ -31,12 +31,14 @@ jobs:
         uses: astral-sh/ruff-action@v3
         with:
           args: check --output-format=github
-      - name: Check dependencies with import-linter
+      - name: Check import dependencies with import-linter
         run: |
-          python -m venv venv
-          source venv/bin/activate
           pip install import-linter
           PYTHONPATH=source lint-imports
+      - name: Looking for dead code with vulture
+        run: |
+          pip install vulture
+          vulture
 
   build-docker-db:
     name: Build docker db

.vulture.ignore

@@ -1,8 +1,12 @@
 [tool.ruff.lint]
 preview = true
-select = ["E101", "E225", "E23", "E24", "E3", "E4", "E7", "E9", "F", "PLR0402", "RET506", "TID252", "UP032", "W29"]
+select = ["ARG003", "ARG005", "B00", "E101", "E20", "E225", "E23", "E24", "E3", "E4", "E7", "E9", "F", "FURB142", "FURB145", "FURB148", "PLR0402", "RET506", "RUF029", "RUF100", "TID252", "UP032", "W29", "W391"]
 ignore = ["E402", "E711", "E712", "E721", "E722"]
 
+[tool.vulture]
+paths = ["source/app", ".vulture.ignore"]
+ignore_decorators = ["@*.route", "@app.*", "@*.post", "@*.get", "@*.put", "@*.delete", "@pre_load", "@post_load"]
+
 [tool.importlinter]
 root_package = "app"
 include_external_packages = true

pyproject.toml

@@ -27,4 +27,3 @@
 
 def worker_exit(server, worker):
     sys.exit(4)
-

scripts/gunicorn-cfg.py

@@ -42,4 +42,3 @@ def upgrade():
 
 def downgrade():
     pass
-

source/app/alembic/versions/10a7616f3cc7_add_module_types.py

@@ -93,4 +93,3 @@ def upgrade():
 def downgrade():
     op.drop_column('ioc_type', 'type_validation_regex')
     op.drop_column('ioc_type', 'type_validation_expect')
-

source/app/alembic/versions/ad4e0cd17597_add_ioctype_validation.py

@@ -57,4 +57,3 @@ def upgrade():
 
 def downgrade():
     pass
-

source/app/alembic/versions/cd519d2d24df_password_policy_edition.py

@@ -61,4 +61,3 @@ def downgrade():
 
     # Drop AlertSimilarity table
     op.drop_table('alert_similarity')
-

source/app/alembic/versions/d5a720d1b99b_add_alerts_indexes.py

@@ -29,4 +29,3 @@ def __getitem__(self, index: slice) -> any:
 
     def __len__(self) -> int:
         return self._total
-

source/app/blueprints/graphql/sliced_result.py

@@ -92,7 +92,7 @@ def customer_edit_contact_modal(client_id, contact_id, caseid, url_redir):
     if url_redir:
         return redirect(url_for('manage_customers.manage_customers', cid=caseid))
 
-    contact = get_client_contact(client_id, contact_id)
+    contact = get_client_contact(contact_id)
     if not contact:
         return response_error(f"Invalid Contact ID {contact_id}")