In order to uniformize field names, case_customer field is renamed case_customer_id for POST /api/v2/cases

Author: c8y3

source/app/blueprints/rest/v2/cases/__init__.py

@@ -63,7 +63,12 @@ def create_case():
     """
 
     try:
-        case = cases_create(request.get_json())
+        # TODO this is a bit of a hack, so that we have everywhere case_customer_id.
+        #  Should be moved down into method cases_update. But careful with the legacy.
+        request_data = request.get_json()
+        request_data['case_customer'] = request_data['case_customer_id']
+
+        case = cases_create(request_data)
         return response_api_created(CaseSchemaForAPIV2().dump(case))
     except BusinessProcessingError as e:
         return response_api_error(e.get_message(), e.get_data())

tests/iris.py

@@ -68,7 +68,7 @@ def create_dummy_case(self):
         body = {
             'case_name': 'case name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         }
         response = self._api.post('/api/v2/cases', body).json()

tests/tests_rest_cases.py

@@ -45,7 +45,7 @@ def test_create_case_should_return_201(self):
         response = self._subject.create('/api/v2/cases', {
             'case_name': 'name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         })
         self.assertEqual(201, response.status_code)
@@ -54,15 +54,15 @@ def test_create_case_with_spurious_slash_should_return_404(self):
         response = self._subject.create('/api/v2/cases/', {
             'case_name': 'name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         })
         self.assertEqual(404, response.status_code)
 
     def test_create_case_with_missing_name_should_return_400(self):
         response = self._subject.create('/api/v2/cases', {
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         })
         self.assertEqual(400, response.status_code)
@@ -71,7 +71,7 @@ def test_create_case_with_classification_id_should_set_classification_id(self):
         response = self._subject.create('/api/v2/cases', {
             'case_name': 'name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': '',
             'classification_id': 2
         }).json()
@@ -89,7 +89,7 @@ def test_get_case_should_return_case_data(self):
         response = self._subject.create('/api/v2/cases', {
             'case_name': 'name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         }).json()
         identifier = response['case_id']
@@ -100,7 +100,7 @@ def test_delete_case_should_return_204(self):
         response = self._subject.create('/api/v2/cases', {
             'case_name': 'name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         }).json()
         identifier = response['case_id']
@@ -111,7 +111,7 @@ def test_get_case_should_return_404_after_it_is_deleted(self):
         response = self._subject.create('/api/v2/cases', {
             'case_name': 'name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         }).json()
         identifier = response['case_id']
@@ -132,7 +132,7 @@ def test_get_cases_should_filter_on_case_name(self):
         response = self._subject.create('/api/v2/cases', {
             'case_name': 'test_get_cases_should_filter_on_case_name',
             'case_description': 'description',
-            'case_customer': 1,
+            'case_customer_id': 1,
             'case_soc_id': ''
         }).json()
         case_identifier = response['case_id']
@@ -179,10 +179,11 @@ def test_create_case_should_return_data_with_case_customer_when_case_customer_is
         body = {
             'case_name': 'case name',
             'case_description': 'description',
-            'case_customer': '',
+            'case_customer_id': '',
             'case_soc_id': ''
         }
         response = self._subject.create('/api/v2/cases', body).json()
+        # FIXME: should really be case_customer_id here, rather than case_customer
         self.assertIn('case_customer', response['data'])
 
     def test_update_case_should_not_fail(self):