remove unneeded passing of Pimple $app

iolloyd · iolloyd · commit f21fd45c4b6c · 2014-05-07T12:07:02.000+02:00
The $app variable is passed needlessly to getOrmDefaults
diff --git a/src/Dflydev/Pimple/Provider/DoctrineOrm/DoctrineOrmServiceProvider.php b/src/Dflydev/Pimple/Provider/DoctrineOrm/DoctrineOrmServiceProvider.php
@@ -38,7 +38,7 @@ class DoctrineOrmServiceProvider
 {
     public function register(\Pimple $app)
     {
-        foreach ($this->getOrmDefaults($app) as $key => $value) {
+        foreach ($this->getOrmDefaults() as $key => $value) {
             if (!isset($app[$key])) {
                 $app[$key] = $value;
             }
@@ -375,7 +375,7 @@ public function register(\Pimple $app)
      *
      * @return array
      */
-    protected function getOrmDefaults(\Pimple $app)
+    protected function getOrmDefaults()
     {
         return array(
             'orm.proxies_dir' => __DIR__.'/../../../../../../../../cache/doctrine/proxies',

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ class DoctrineOrmServiceProvider`
`38`	`38`	`{`
`39`	`39`	`public function register(\Pimple $app)`
`40`	`40`	`{`
`41`		`- foreach ($this->getOrmDefaults($app) as $key => $value) {`
	`41`	`+ foreach ($this->getOrmDefaults() as $key => $value) {`
`42`	`42`	`if (!isset($app[$key])) {`
`43`	`43`	`$app[$key] = $value;`
`44`	`44`	`}`
`@@ -375,7 +375,7 @@ public function register(\Pimple $app)`
`375`	`375`	`*`
`376`	`376`	`* @return array`
`377`	`377`	`*/`
`378`		`- protected function getOrmDefaults(\Pimple $app)`
	`378`	`+ protected function getOrmDefaults()`
`379`	`379`	`{`
`380`	`380`	`return array(`
`381`	`381`	`'orm.proxies_dir' => __DIR__.'/../../../../../../../../cache/doctrine/proxies',`