Skip to content

Passing all the options to phantomjs causes issues when using vendor scripts with certain characters on windows #74

@Nysosis

Description

@Nysosis

If I've got the following config:

		{
			jasmineVersion: 2.4,
			integration: true,
			keepRunner: true,
			vendor: [
				"https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js",
				"https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.11.2/moment.min.js",
				"node_modules/jasmine-jquery/lib/jasmine-jquery.js",
				"node_modules/humanize-duration/humanize-duration.js",
				"node_modules/zebra_dialog/public/javascript/zebra_dialog.src.js",
				"./src/js/!(*.spec.js|!(*.js))"
			]
		}

The execution will fail, I believe it's down to the '!' in the pattern, not working well with windows (could be a *nix thing too, I've not the environment to test on).

All the arguments are being passed across at index.js#L220 and index.js#L181, however from what I can see, the jasmine-runner.js only really cares about the abortOnFail property from the configuration at line L16.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions