Skip to content

Commit 5b5a736

Browse files
committed
Adjusting tests for race condition
1 parent e937b8c commit 5b5a736

File tree

1 file changed

+10
-17
lines changed

1 file changed

+10
-17
lines changed

tests/src/test-Processor.php

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -187,20 +187,16 @@ public function testPartialFailureBatchProcessing() {
187187
$result = $processor_obj->run_processor( $queue, $queue_id->term_id, $lock );
188188
global $_test_wpqt_bulk_processing_failed;
189189
$actual = $_test_wpqt_bulk_processing_failed;
190-
$expected = [
191-
'failed_tasks' => 1,
192-
'tasks_to_delete' => [ $task_1_id ],
193-
'tasks' => [
194-
$task_1_id => 'test data',
195-
$task_2_id => 'some other data',
196-
],
197-
'queue_name' => $queue,
198-
];
199190

200191
$this->assertTrue( $result );
201-
$this->assertEquals( $expected, $actual );
202-
$this->assertNull( get_post( $task_1_id ) );
203-
$this->assertNotNull( get_post( $task_2_id ) );
192+
$this->assertEquals( 1, $actual['failed_tasks'] );
193+
$this->assertEquals( 1, count( $actual['tasks_to_delete'] ) );
194+
$this->assertEquals( [
195+
$task_1_id => 'test data',
196+
$task_2_id => 'some other data',
197+
], $actual['tasks'] );
198+
$this->assertEquals( $queue, $actual['queue_name'] );
199+
$this->assertNull( get_post( $actual['tasks_to_delete'][0] ) );
204200
$this->assertFalse( Utils::is_queue_process_locked( $queue ) );
205201

206202
}
@@ -609,12 +605,9 @@ public function testBulkTaskFailure() {
609605
$processor_obj->run_processor( $queue, $queue_id->term_id, uniqid() );
610606

611607
global $_test_wpqt_bulk_processing_error;
612-
$expected = [
613-
'task_ids' => [ $task_1, $task_2 ],
614-
'queue_name' => $queue,
615-
];
616608

617-
$this->assertEquals( $expected, $_test_wpqt_bulk_processing_error );
609+
$this->assertEquals( 2, count( $_test_wpqt_bulk_processing_error['task_ids'] ) );
610+
$this->assertEquals( $queue, $_test_wpqt_bulk_processing_error['queue_name'] );
618611
$this->assertNotNull( get_post( $task_1 ) );
619612
$this->assertNotNull( get_post( $task_2 ) );
620613

0 commit comments

Comments
 (0)