Merge pull request #61 from CodeProKid/bug/hide-admin-ui

Hiding admin UI from non-admins

Author: David Leal

.travis.yml

@@ -18,6 +18,8 @@ cache:
 
 matrix:
   include:
+    - php: 7.2
+      env: WP_VERSION=latest
     - php: 7.1
       env: WP_VERSION=latest
     - php: 7.0
@@ -48,4 +50,4 @@ script:
     fi
 
 after_success:
-  - bash <(curl -s https://codecov.io/bash) -t $CODECOV_TOKEN
+  - bash <(curl -s https://codecov.io/bash) -t $CODECOV_TOKEN

composer.json

@@ -18,5 +18,8 @@
     "classmap": [
       "src/"
     ]
+  },
+  "require-dev": {
+    "phpunit/phpunit": "5.6"
   }
-}
+}

src/Register.php

@@ -6,6 +6,8 @@
  */
 class Register {
 
+	const POST_TYPE = 'wpqt-task';
+
 	/**
 	 * Sets up all of the functionality to run in the proper hook
 	 */
@@ -24,6 +26,10 @@ public function setup() {
 		// Performance improvement for VIP
 		add_filter( 'wpcom_async_transition_post_status_schedule_async', [ $this, 'disable_post_transition' ], 10, 2 );
 
+		if ( true === Utils::debug_on() ) {
+			add_action( 'admin_menu', [ $this, 'hide_admin_ui' ] );
+		}
+
 	}
 
 	/**
@@ -70,7 +76,7 @@ public function register_taxonomy() {
 			'graphql_plural_name'   => 'queues',
 		];
 
-		register_taxonomy( 'task-queue', 'wpqt-task', $args );
+		register_taxonomy( 'task-queue', self::POST_TYPE, $args );
 
 	}
 
@@ -119,7 +125,7 @@ public function register_post_type() {
 			'graphql_plural_name'   => 'tasks',
 		];
 
-		register_post_type( 'wpqt-task', $args );
+		register_post_type( self::POST_TYPE, $args );
 
 	}
 
@@ -137,7 +143,7 @@ public function blacklist_post_type( $post_types ) {
 			$post_types = [];
 		}
 
-		$post_types[] = 'wpqt-task';
+		$post_types[] = self::POST_TYPE;
 
 		return $post_types;
 	}
@@ -157,12 +163,24 @@ public function disable_post_transition( $value, $args ) {
 			return $value;
 		}
 
-		if ( 'wpqt-task' === get_post_type( absint( $args['post_id'] ) ) ) {
+		if ( self::POST_TYPE === get_post_type( absint( $args['post_id'] ) ) ) {
 			$value = false;
 		}
 
 		return $value;
 
 	}
 
+	/**
+	 * Hides the admin UI when the plugin is in debug mode from non-admins
+	 *
+	 * @access public
+	 * @return void
+	 */
+	public function hide_admin_ui() {
+		if ( ! current_user_can( 'manage_options' ) ) {
+			remove_menu_page( 'edit.php?post_type=' . self::POST_TYPE );
+		}
+	}
+
 }

tests/src/test-Processor.php

@@ -187,20 +187,16 @@ public function testPartialFailureBatchProcessing() {
 		$result = $processor_obj->run_processor( $queue, $queue_id->term_id, $lock );
 		global $_test_wpqt_bulk_processing_failed;
 		$actual = $_test_wpqt_bulk_processing_failed;
-		$expected = [
-			'failed_tasks' => 1,
-			'tasks_to_delete' => [ $task_1_id ],
-			'tasks' => [
-				$task_1_id => 'test data',
-				$task_2_id => 'some other data',
-			],
-			'queue_name' => $queue,
-		];
 
 		$this->assertTrue( $result );
-		$this->assertEquals( $expected, $actual );
-		$this->assertNull( get_post( $task_1_id ) );
-		$this->assertNotNull( get_post( $task_2_id ) );
+		$this->assertEquals( 1, $actual['failed_tasks'] );
+		$this->assertEquals( 1, count( $actual['tasks_to_delete'] ) );
+		$this->assertEquals( [
+			$task_1_id => 'test data',
+			$task_2_id => 'some other data',
+		], $actual['tasks'] );
+		$this->assertEquals( $queue, $actual['queue_name'] );
+		$this->assertNull( get_post( $actual['tasks_to_delete'][0] ) );
 		$this->assertFalse( Utils::is_queue_process_locked( $queue ) );
 
 	}
@@ -609,12 +605,9 @@ public function testBulkTaskFailure() {
 		$processor_obj->run_processor( $queue, $queue_id->term_id, uniqid() );
 
 		global $_test_wpqt_bulk_processing_error;
-		$expected = [
-			'task_ids' => [ $task_1, $task_2 ],
-			'queue_name' => $queue,
-		];
 
-		$this->assertEquals( $expected, $_test_wpqt_bulk_processing_error );
+		$this->assertEquals( 2, count( $_test_wpqt_bulk_processing_error['task_ids'] ) );
+		$this->assertEquals( $queue, $_test_wpqt_bulk_processing_error['queue_name'] );
 		$this->assertNotNull( get_post( $task_1 ) );
 		$this->assertNotNull( get_post( $task_2 ) );