Skip to content

Commit 206b6f9

Browse files
carla-terbovenPeterKraus
authored andcommitted
Change reverse scan param format (#216)
* Change reverse scan param format * Add test for issue 217 * Change column ID for CV to Rcmp * Add thank you note for Niklas CV files (#216)
1 parent 494ff1a commit 206b6f9

File tree

8 files changed

+9416
-2
lines changed

8 files changed

+9416
-2
lines changed

docs/source/version.6_2.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,4 @@ Bug fixes in ``yadg-next`` include:
2020

2121
- Fixed metadata extraction in :mod:`yadg.extractors.eclab.mpt` where ``control_*`` columns would not match the names present in the corresponding ``mpr`` files.
2222
- Added further ``Set I/C`` parameters. Thanks to `@Locki3 <https://github.com/Locki3>`_ for providing test files.
23+
- Fixed ``param format`` and ``data_column`` in CV files generated with EC-Lab version 11.50 using the :mod:`yadg.extractors.eclab.mpr` module. Thank you to J.N. Hausmann from Helmholtz-Zentrum Berlin für Materialien und Energie for providing the test files.

src/yadg/extractors/eclab/mpr_columns.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
392: ("<f4", "<E2>", "V"),
135135
422: ("<f4", "Phase(Zstack)", "deg"),
136136
423: ("<f4", "|Zstack|", "Ω"),
137-
424: ("<f4", "Re(Zstack)", "Ω"),
137+
424: ("<f4", "Rcmp", "Ω"),
138138
425: ("<f4", "-Im(Zstack)", "Ω"),
139139
426: ("<f4", "<Estack>", "V"),
140140
430: ("<f4", "Phase(Zwe-ce)", "deg"),

src/yadg/extractors/eclab/techniques.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
("E2 (V)", "<f4"),
212212
("E2 (V) vs.", "|u4"),
213213
("nc cycles", "|u4"),
214-
("Reverse Scan", "|u1"),
214+
("Reverse Scan", "|u4"),
215215
("Ef (V)", "<f4"),
216216
("Ef (V) vs.", "|u4"),
217217
]

tests/test_x_eclab.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def compare_params(left, right):
4040
("cp.issue_149", "de_DE"),
4141
("cv", "en_US"),
4242
("cv.issue_149", "de_DE"),
43+
("cv.issue_217", "de_DE"),
4344
("cva.issue_135", "en_US"),
4445
("cva.issue_202", "en_US"),
4546
("gcpl", "en_US"),
445 KB
Binary file not shown.
1.72 MB
Binary file not shown.

tests/test_x_eclab/cv.issue_217.mpt

Lines changed: 9412 additions & 0 deletions
Large diffs are not rendered by default.
2 MB
Binary file not shown.

0 commit comments

Comments
 (0)