touchstone.snp: Fix picovna timestamp parsing. (#204)

* Fix timestamp parsing for touchstone.

* tests

* docs

* ruff changes.

Author: PeterKraus

docs/source/version.6_1.rst

@@ -23,3 +23,4 @@ Breaking changes in ``yadg-6.1`` are:
 Bug fixes in ``yadg-6.1`` include:
 
   - Fixed metadata extraction and added support for another version of the CVA technique in :mod:`yadg.extractors.eclab.mpr`. Thanks to `@acavell <https://github.com/acavell>`_ for providing test files.
+  - Fixed timestamp parsing for D/M/Y formats of PicoVNA files in :mod:`yadg.extractors.touchstone.snp`.

src/yadg/extractors/ezchrom/asc.py

@@ -83,15 +83,15 @@ def extract(
                 timezone=timezone,
             )
         if line.startswith("Sampling Rate:"):
-            assert (
-                "Hz" in line
-            ), f"datasc: Incorrect units for rate in file {fn}: {line}"
+            assert "Hz" in line, (
+                f"datasc: Incorrect units for rate in file {fn}: {line}"
+            )
             parts = line.split("\t")
             samplerates = [float(each.strip()) for each in parts[1:-1]]
         if line.startswith("Total Data Points:"):
-            assert (
-                "Pts." in line
-            ), f"datasc: Incorrect units for number of points in file {fn}: {line}"
+            assert "Pts." in line, (
+                f"datasc: Incorrect units for number of points in file {fn}: {line}"
+            )
             parts = line.split("\t")
             npoints = [int(each.strip()) for each in parts[1:-1]]
         if line.startswith("X Axis Title:"):
@@ -127,9 +127,9 @@ def extract(
     data = {}
     units = {}
     for ti, npts in enumerate(npoints):
-        assert (
-            xunits[ti] == "Minutes"
-        ), f"datasc: X units label of trace {ti} in {fn} was not understood."
+        assert xunits[ti] == "Minutes", (
+            f"datasc: X units label of trace {ti} in {fn} was not understood."
+        )
         dt = 60
         xmul = xmuls[ti] * dt / samplerates[ti]
         ymul = ymuls[ti]

src/yadg/extractors/fhimcpt/vna.py

@@ -51,9 +51,9 @@ def extract(
 ) -> DataTree:
     with open(fn, "r", encoding=encoding) as infile:
         lines = infile.readlines()
-    assert (
-        len(lines) > 2
-    ), f"qftrace: Only {len(lines)-1} points supplied in {fn}; fitting impossible."
+    assert len(lines) > 2, (
+        f"qftrace: Only {len(lines) - 1} points supplied in {fn}; fitting impossible."
+    )
 
     # process header
     bw = [10000.0, 1.0]

src/yadg/extractors/phi/spe.py

@@ -305,7 +305,7 @@ def _process_traces(spe: list[bytes], trace_defs: list[dict]) -> dict:
             retstep=True,
         )
         # Construct data from trace_header
-        data_dtype = np.dtype(f'{trace_header["data_dtype"].decode()}')
+        data_dtype = np.dtype(f"{trace_header['data_dtype'].decode()}")
         data_offset = trace_header["end_of_data"] - trace_header["num_data_bytes"]
         datapoints = np.frombuffer(
             data,

src/yadg/extractors/touchstone/snp.py

@@ -124,10 +124,12 @@ def process_comments(lines: list[str], tz: str) -> dict:
         pass
     # PicoVNA 108 files
     elif "Ref Plane:" in comstr and len(lines) == 3:
-        fmt = "%m/%d/%Y  %I:%M:%S %p"
-        uts = dgutils.str_to_uts(
-            timestamp=lines[0], timezone=tz, format=fmt, strict=False
-        )
+        for fmt in ["%m/%d/%Y  %I:%M:%S %p", "%d/%m/%Y  %H:%M:%S"]:
+            uts = dgutils.str_to_uts(
+                timestamp=lines[0], timezone=tz, format=fmt, strict=False
+            )
+            if uts is not None:
+                break
         attrs["Ref Plane"] = lines[1].split(":")[1].strip()
         attrs["Model"] = "PicoVNA 108"
     # Agilent N523* and E50* export

src/yadg/main.py

@@ -31,7 +31,7 @@ def run_with_arguments():
     parser.add_argument(
         "--version",
         action="version",
-        version=f'%(prog)s version {metadata.version("yadg")}',
+        version=f"%(prog)s version {metadata.version('yadg')}",
     )
 
     verbose = argparse.ArgumentParser(add_help=False)

src/yadg/subcommands.py

@@ -151,7 +151,7 @@ def preset(
 
     """
     assert os.path.exists(folder) and os.path.isdir(folder), (
-        f"Supplied folder path '{folder}' does not exist " "or is not a valid folder."
+        f"Supplied folder path '{folder}' does not exist or is not a valid folder."
     )
 
     if not os.path.isabs(folder) and not process:
@@ -161,7 +161,7 @@ def preset(
         )
 
     assert os.path.exists(preset) and os.path.isfile(preset), (
-        f"Supplied preset path '{preset}' does not exist " "or is not a valid file."
+        f"Supplied preset path '{preset}' does not exist or is not a valid file."
     )
 
     logger.info("Reading input file from '%s'.", preset)
@@ -223,7 +223,7 @@ def extract(
     path = Path(infile)
 
     assert path.is_file(), (
-        f"Supplied object filename '{infile}' does not exist " "or is not a valid file."
+        f"Supplied object filename '{infile}' does not exist or is not a valid file."
     )
 
     if outfile is None:

tests/test_schema.py

@@ -182,7 +182,7 @@ def test_datagram_from_schema_file(inp_fn, ts, datadir):
     os.chdir(datadir)
     ret = datagram_from_file(inp_fn)
     assert len(ret.children) == ts["nsteps"], (
-        "wrong number of steps: " f"got: {len(ret.children)}, expected: {ts['nsteps']}"
+        f"wrong number of steps: got: {len(ret.children)}, expected: {ts['nsteps']}"
     )
     for k, v in ts["kwargs"].items():
         assert ret[ts["step"]][k][ts["item"]] == v, "kwargs not passed correctly"

tests/test_timezones.py

@@ -33,21 +33,21 @@ def test_isotimestamp_parsing_utc(datadir):
     dg = datagram_from_file("iso_utc.json")
 
     assert dg["0"].uts[0] == 1622557825.0, "Z-suffix parsed to 'uts' correctly"
-    assert (
-        dg["0"].uts[1] == 1622557825.0 + 7200 + 1
-    ), "±HH:MM-suffix parsed to 'uts' correctly"
-    assert (
-        dg["0"].uts[2] == 1622557825.0 + 2
-    ), "no suffix with timezone = UTC parsed to 'uts' correctly"
+    assert dg["0"].uts[1] == 1622557825.0 + 7200 + 1, (
+        "±HH:MM-suffix parsed to 'uts' correctly"
+    )
+    assert dg["0"].uts[2] == 1622557825.0 + 2, (
+        "no suffix with timezone = UTC parsed to 'uts' correctly"
+    )
 
 
 def test_isotimestamp_parsing_cet(datadir):
     os.chdir(datadir)
     dg = datagram_from_file("iso_cet.json")
     assert dg["0"].uts[0] == 1622557825.0, "Z-suffix parsed to 'uts' correctly"
-    assert (
-        dg["0"].uts[1] == 1622557825.0 + 7200 + 1
-    ), "±HH:MM-suffix parsed to 'uts' correctly"
-    assert (
-        dg["0"].uts[2] == 1622557825.0 - 7200 + 2
-    ), "no suffix with timezone = CEST parsed to 'uts' correctly"
+    assert dg["0"].uts[1] == 1622557825.0 + 7200 + 1, (
+        "±HH:MM-suffix parsed to 'uts' correctly"
+    )
+    assert dg["0"].uts[2] == 1622557825.0 - 7200 + 2, (
+        "no suffix with timezone = CEST parsed to 'uts' correctly"
+    )

tests/test_x_touchstone_snp.py

@@ -9,6 +9,7 @@
     "infile, locale",
     [
         ("picovna.s1p", "en_GB"),
+        ("picovna_DMY.s1p", "en_GB"),
         ("Device_r_40um.s1p", "en_GB"),
         ("Device_r_60um.s1p", "en_GB"),
         ("Fig8_0.6cm.s1p", "en_GB"),