fix tests

Author: shivaji-kharse

posting/index.go

@@ -14,7 +14,6 @@ import (
 	"fmt"
 	"math"
 	"os"
-	"strconv"
 	"strings"
 	"sync/atomic"
 	"time"
@@ -1406,8 +1405,7 @@ func rebuildVectorIndex(ctx context.Context, factorySpecs []*tok.FactoryCreateSp
 			StartKey: x.DataKey(rb.Attr, 0),
 		})
 
-		indexer.SetDimension(dimension)
-		addDimensionOptionInSchema(rb.CurrentSchema, dimension)
+		indexer.SetDimension(rb.CurrentSchema, dimension)
 	}
 
 	fmt.Println("Selecting vector dimension to be:", dimension)
@@ -1457,7 +1455,6 @@ func rebuildVectorIndex(ctx context.Context, factorySpecs []*tok.FactoryCreateSp
 
 	if count < indexer.NumSeedVectors() {
 		indexer.SetNumPasses(0)
-
 	}
 
 	for pass_idx := range indexer.NumBuildPasses() {
@@ -1489,21 +1486,24 @@ func rebuildVectorIndex(ctx context.Context, factorySpecs []*tok.FactoryCreateSp
 		indexer.EndBuild()
 	}
 
-	txn := NewTxn(rb.StartTs)
 	centroids := indexer.GetCentroids()
 
-	bCentroids, err := json.Marshal(centroids)
-	if err != nil {
-		return err
-	}
+	if centroids != nil {
+		txn := NewTxn(rb.StartTs)
 
-	if err := addCentroidInDB(ctx, rb.Attr, bCentroids, txn); err != nil {
-		return err
-	}
-	txn.Update()
-	writer := NewTxnWriter(pstore)
-	if err := txn.CommitToDisk(writer, rb.StartTs); err != nil {
-		return err
+		bCentroids, err := json.Marshal(centroids)
+		if err != nil {
+			return err
+		}
+
+		if err := addCentroidInDB(ctx, rb.Attr, bCentroids, txn); err != nil {
+			return err
+		}
+		txn.Update()
+		writer := NewTxnWriter(pstore)
+		if err := txn.CommitToDisk(writer, rb.StartTs); err != nil {
+			return err
+		}
 	}
 
 	numIndexPasses := indexer.NumIndexPasses()
@@ -1705,17 +1705,6 @@ func addCentroidInDB(ctx context.Context, attr string, vec []byte, txn *Txn) err
 	return nil
 }
 
-func addDimensionOptionInSchema(schema *pb.SchemaUpdate, dimension int) {
-	for _, vs := range schema.IndexSpecs {
-		if vs.Name == "partionedhnsw" {
-			vs.Options = append(vs.Options, &pb.OptionPair{
-				Key:   "vectorDimension",
-				Value: strconv.Itoa(dimension),
-			})
-		}
-	}
-}
-
 // rebuildTokIndex rebuilds index for a given attribute.
 // We commit mutations with startTs and ignore the errors.
 func rebuildTokIndex(ctx context.Context, rb *IndexRebuild) error {

tok/hnsw/persistent_hnsw.go

@@ -13,6 +13,7 @@ import (
 	"time"
 
 	"github.com/golang/glog"
+	"github.com/hypermodeinc/dgraph/v25/protos/pb"
 	c "github.com/hypermodeinc/dgraph/v25/tok/constraints"
 	"github.com/hypermodeinc/dgraph/v25/tok/index"
 	opt "github.com/hypermodeinc/dgraph/v25/tok/options"
@@ -125,7 +126,7 @@ func (ph *persistentHNSW[T]) Dimension() int {
 	return 0
 }
 
-func (ph *persistentHNSW[T]) SetDimension(dimension int) {
+func (ph *persistentHNSW[T]) SetDimension(schema *pb.SchemaUpdate, dimension int) {
 	glog.Info("not implemented")
 }
 

tok/index/index.go

@@ -8,6 +8,7 @@ package index
 import (
 	"context"
 
+	"github.com/hypermodeinc/dgraph/v25/protos/pb"
 	c "github.com/hypermodeinc/dgraph/v25/tok/constraints"
 	opts "github.com/hypermodeinc/dgraph/v25/tok/options"
 )
@@ -144,7 +145,7 @@ type VectorIndex[T c.Float] interface {
 	EndBuild() []int
 	NumThreads() int
 	Dimension() int
-	SetDimension(dimension int)
+	SetDimension(schema *pb.SchemaUpdate, dimension int)
 }
 
 // A Txn is an interface representation of a persistent storage transaction,

tok/partitioned_hnsw/partitioned_hnsw.go

@@ -7,8 +7,10 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strconv"
 	"sync"
 
+	"github.com/hypermodeinc/dgraph/v25/protos/pb"
 	c "github.com/hypermodeinc/dgraph/v25/tok/constraints"
 	hnsw "github.com/hypermodeinc/dgraph/v25/tok/hnsw"
 	"github.com/hypermodeinc/dgraph/v25/tok/index"
@@ -104,8 +106,16 @@ func (ph *partitionedHNSW[T]) Dimension() int {
 	return ph.vectorDimension
 }
 
-func (ph *partitionedHNSW[T]) SetDimension(dimension int) {
+func (ph *partitionedHNSW[T]) SetDimension(schema *pb.SchemaUpdate, dimension int) {
 	ph.vectorDimension = dimension
+	for _, vs := range schema.IndexSpecs {
+		if vs.Name == "partionedhnsw" {
+			vs.Options = append(vs.Options, &pb.OptionPair{
+				Key:   "vectorDimension",
+				Value: strconv.Itoa(dimension),
+			})
+		}
+	}
 }
 
 func (ph *partitionedHNSW[T]) NumIndexPasses() int {