updated comments

Author: darkcoderrises

posting/list_test.go

@@ -18,6 +18,7 @@ package posting
 
 import (
 	"context"
+	"fmt"
 	"math"
 	"math/rand"
 	"os"
@@ -461,10 +462,12 @@ func TestReadSingleValue(t *testing.T) {
 		}
 		writer.Flush()
 
-		for j := 3; j < i+6; j++ {
+		for j := 2; j < i+6; j++ {
 			k, err, _ := GetSingleValueForKey(key, uint64(j))
 			require.NoError(t, err)
-			checkValue(t, ol, string(k.Postings[0].Value), uint64(j))
+			p := getFirst(t, k, uint64(j))
+			fmt.Println("Here", p)
+			checkValue(t, ol, string(p.Value), uint64(j))
 		}
 
 	}

posting/lists.go

@@ -178,7 +178,7 @@ func (lc *LocalCache) getSingleInternal(key []byte, readFromDisk bool) (*List, e
 		var err error
 		pl, err, k = GetSingleValueForKey(key, lc.startTs)
 		if err != nil {
-			return nil, err
+			return pl, err
 		}
 	} else {
 		pl = &List{
@@ -196,6 +196,7 @@ func (lc *LocalCache) getSingleInternal(key []byte, readFromDisk bool) (*List, e
 		pl.setMutation(lc.startTs, delta)
 	}
 	lc.RUnlock()
+	fmt.Println("Here6")
 	return pl, nil
 }
 

posting/mvcc.go

@@ -493,20 +493,42 @@ func GetSingleValueForKey(key []byte, readTs uint64) (*List, error, int) {
 	txn := pstore.NewTransactionAt(readTs, false)
 	item, err := txn.Get(key)
 	if err != nil {
-		return nil, err, 0
+		return l, err, 0
 	}
 	k := 0
 
-	err = item.Value(func(val []byte) error {
-		k = len(key) + len(val)
-		if err := l.plist.Unmarshal(val); err != nil {
-			return err
+	l.maxTs = x.Max(l.maxTs, item.Version())
+
+	switch item.UserMeta() {
+	case BitEmptyPosting:
+		l.minTs = item.Version()
+	case BitCompletePosting:
+		if err := unmarshalOrCopy(l.plist, item); err != nil {
+			return l, nil, k
 		}
-		return nil
-	})
+		l.minTs = item.Version()
 
-	if err != nil {
-		return nil, err, 0
+	case BitDeltaPosting:
+		err := item.Value(func(val []byte) error {
+			pl := &pb.PostingList{}
+			if err := pl.Unmarshal(val); err != nil {
+				return err
+			}
+			pl.CommitTs = item.Version()
+			for _, mpost := range pl.Postings {
+				// commitTs, startTs are meant to be only in memory, not
+				// stored on disk.
+				mpost.CommitTs = item.Version()
+			}
+			if l.mutationMap == nil {
+				l.mutationMap = make(map[uint64]*pb.PostingList)
+			}
+			l.mutationMap[pl.CommitTs] = pl
+			return nil
+		})
+		if err != nil {
+			return l, nil, k
+		}
 	}
 
 	return l, nil, k

worker/task.go

@@ -392,15 +392,26 @@ func (qs *queryState) handleValuePostings(ctx context.Context, args funcArgs) er
 
 			// Get or create the posting list for an entity, attribute combination.
 			var pl *posting.List
-			pickMultiplePostings := q.ExpandAll || (listType && len(q.Langs) == 0)
+			pickMultiplePostings := q.DoCount || q.ExpandAll || listType || len(q.Langs) > 0
 
 			var vals []types.Val
 			fcs := &pb.FacetsList{FacetsList: make([]*pb.Facets, 0)} // TODO Figure out how it is stored
 
-			if pickMultiplePostings {
-				pl, err = qs.cache.Get(key)
+			if !pickMultiplePostings {
+				//fmt.Println("HERE GETTING SINGLE KEY", key)
+				//vals, fcs, err = retrieveValuesAndFacets(args, pl, facetsTree, listType)
+				pl, _ = qs.cache.GetSingle(key)
+
+				//vals1, _, _ := retrieveValuesAndFacets(args, pl1, facetsTree, listType)
+				//fmt.Println("Here getting key", len(vals), vals, len(vals1), vals1, len(vals) != len(vals1))
+				//if len(vals) != len(vals1) {
+				//	fmt.Println("HERE")
+				//}
+				//vals, fcs, err = retrieveValuesAndFacets(args, pl, facetsTree, listType)
+				//fmt.Println("Here getting full key", len(vals), len(fcs.FacetsList), vals[0])
 			} else {
-				pl, err = qs.cache.GetSingle(key)
+
+				pl, err = qs.cache.Get(key)
 			}
 			if err != nil {
 				return err