Skip to content

Commit d3257e1

Browse files
committed
refactor: improve test workflow organization and clarity
- Add actions:write and checks:write permissions for better workflow control - Rename jobs and steps for improved clarity and consistency - Reorder steps to check protobuf generation before code quality - Add trunk code quality checks as separate workflow step - Standardize step naming across all jobs - Add whitespace formatting in ci-pydgraph-tests workflow
1 parent b4d5c43 commit d3257e1

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

.github/workflows/test.yml

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ on:
1515
- cron: 1 0 * * * # run workflow daily
1616
permissions:
1717
contents: read
18+
actions: write
19+
checks: write
1820
jobs:
1921
check-code-quality:
2022
name: Check Code Quality
@@ -25,20 +27,22 @@ jobs:
2527
with:
2628
repository: dgraph-io/pydgraph
2729
ref: ${{ github.ref }}
28-
- name: Setup pydgraph tooling
30+
- name: Setup python runtime and tooling
2931
uses: ./.github/actions/setup-python-and-tooling
3032
with:
3133
python-version: "3.13"
32-
- name: Setup pydgraph virtualenv
34+
- name: Sync python virtualenv
3335
run: INSTALL_MISSING=true make setup
34-
- name: Run pydgraph code quality checks
35-
run: SKIP=trunk-check,trunk-fmt make check # (Skips trunk pre-commit checks, which have their own workflow)
36-
- name: Verify generated protobufs are current
36+
- name: Check generated protobufs are current
3737
run: |
3838
make protogen
3939
git diff --exit-code -- .
40-
test-dgraph-release:
41-
name: Test Python ${{ matrix.python-version }} & DGraph Latest
40+
- name: Run non-trunk code quality checks
41+
run: SKIP=trunk-check,trunk-fmt make check # (Skips trunk checks, which have their own step)
42+
- name: Run trunk code quality checks
43+
uses: dgraph-io/.github/.github/workflows/trunk.yml@main
44+
test-pydgraph-dgraph-latest:
45+
name: Test Pydgraph (Python ${{ matrix.python-version }} / DGraph Latest)
4246
runs-on: ubuntu-latest
4347
strategy:
4448
matrix:
@@ -49,24 +53,24 @@ jobs:
4953
with:
5054
repository: dgraph-io/pydgraph
5155
ref: ${{ github.ref }}
52-
- name: Setup pydgraph tooling
56+
- name: Setup python runtime and tooling
5357
uses: ./.github/actions/setup-python-and-tooling
5458
with:
5559
python-version: ${{ matrix.python-version }}
56-
- name: Pin pydgraph python version
60+
- name: Pin python version
5761
run: uv python pin ${{ matrix.python-version }}
58-
- name: Setup pydgraph virtualenv
62+
- name: Sync python virtualenv
5963
run: INSTALL_MISSING=true make setup
60-
- name: Run pydgraph tests
64+
- name: Run tests
6165
run: make test
62-
test-dgraph-head:
63-
name: Test Python ${{ matrix.python-version }} & DGraph HEAD
66+
test-pydgraph-dgraph-head:
67+
name: Test Pydgraph (Python ${{ matrix.python-version }} / DGraph HEAD)
6468
runs-on: ubuntu-latest
6569
strategy:
6670
matrix:
6771
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
6872
steps:
69-
- name: Checkout Dgraph
73+
- name: Checkout Dgraph main latest
7074
uses: actions/checkout@v5
7175
with:
7276
path: dgraph
@@ -88,14 +92,14 @@ jobs:
8892
path: pydgraph
8993
repository: dgraph-io/pydgraph
9094
ref: ${{ github.ref }}
91-
- name: Setup pydgraph tooling
95+
- name: Setup python runtime and tooling
9296
uses: ./pydgraph/.github/actions/setup-python-and-tooling
9397
with:
9498
python-version: ${{ matrix.python-version }}
95-
- name: Pin pydgraph python version
99+
- name: Pin python version
96100
working-directory: ./pydgraph
97101
run: uv python pin ${{ matrix.python-version }}
98-
- name: Setup pydgraph virtualenv
102+
- name: Sync python virtualenv
99103
working-directory: ./pydgraph
100104
run: INSTALL_MISSING=true make setup
101105
- name: Run tests

0 commit comments

Comments
 (0)