BASE_URL ignored

[kr-nn]

Describe the bug
I run a reverse proxy for my change detection.
I access it via https://mydomain.com/watcher

I have previously had to meddle with the trailing slash for things to work correctly, but now all links including the CSS requests are not including the /watcher in the request/links

Version
v0.39.18

To Reproduce

Steps to reproduce the behavior:
Apache config:

<Location /watcher>
	RequestHeader set X-Forwarded-Prefix /watcher
	RequestHeader set X-Forwarded-Proto $scheme
	RequestHeader set Host __REDACTED__
        ProxyPass "http://10.0.0.15:5000/"
        ProxyPassReverse "http://10.0.0.15:5000/"
</Location>

My environment variables:

Expected behavior
The links to include the subfolder

Screenshots

Additional context
Add any other context about the problem here.

[dgtlmoon]

Not directly a bug in changedetection.io (so far, I think), so i'll move this to discussions

    location /watcher/(.*) {
        proxy_set_header X-Forwarded-Prefix /$1;
        proxy_set_header Host "lemonade.changedetection.io";
        ProxyPass "http://10.0.0.15:5000/"
        ProxyPassReverse "http://10.0.0.15:5000/"
    }

what if you add an extra location with the forward slash? does it fix your problem?

[kr-nn]

Not directly a bug in changedetection.io (so far, I think), so i'll move this to discussions

    location /watcher/(.*) {
        proxy_set_header X-Forwarded-Prefix /$1;
        proxy_set_header Host "lemonade.changedetection.io";
        ProxyPass "http://10.0.0.15:5000/"
        ProxyPassReverse "http://10.0.0.15:5000/"
    }

what if you add an extra location with the forward slash? does it fix your problem?

This is an nginx configuration. Not apache.

[mbugert]

Partially related:
I also tried to run changedetection behind a reverse proxy, but using a subdomain instead of a subdirectory (i.e. changedetection.mydomain.com), and also saw 404's for all static files.
The solution was to remove the trailing slash from the proxy_pass directive. In that sense, the wiki instructions are a bit misleading, since it looks as if the trailing slash is only needed when reverse proxying with a subdirectory.

[dgtlmoon]

So did you update the wiki with a not or improvements?

[mbugert]

I did now. Never figured out how Github wikis work all these years, I thought only contributors could modify the pages to ensure high-quality content...

[kr-nn]

Just an update this is still broken.
The base URL settings at this point include /watcher
There is no reason for the app to continue requesting /

[kr-nn]

Another update after a bunch of trying to figure out how the base_url works.

It seems the base url functionality is completely broken.
regardless what I change, including hardcoding strings the baseurl does not change, nor does it show any changes in the UI.

I changed

changedetection.io/changedetection/store.py#182

from:

env_base_url = os.getenv('BASE_URL','')

to:

env_base_url = os.getenv('BASE_URL','test')

I tested to see if the default base URL changed to "test"
The base URL continued to be ""

Base URL used for the {{ base_url }} token in notifications and RSS links.
Default value is the ENV var 'BASE_URL' (Currently "")

Looking in

changedetection.io/changedetection.py

the class is being called datastore.
The data seems to be saved as json, but the BASE_URL variable is never changed regardless, even if hardcoded.
This should be reopened as a bug report.

[kr-nn]

On a second note, after digging through the code, I found my solution.
It's not stated anywhere in the wiki, but there's an option for the environment variables

USE_X_SETTINGS = 1

Makes the X options in your webserver work, this makes it so X-Forwarded-Prefix "/watcher"
tells chio to use the /watcher sub-directory
I updated the wiki

[dgtlmoon]

@kylernocturnalnerd thanks, sadly, someone had removed that for no good reason, in my original version of the wiki page it was there https://github.com/dgtlmoon/changedetection.io/wiki/Running-changedetection.io-behind-a-reverse-proxy-sub-directory/bc7de0b53c370d028221121a503bb0f7b8b3dc7c