Does this work with indirect buffers?

[irisjae]

I use narrow indirect buffers heavily and decided to try diff-hl. It didn't work for my narrow-indirect buffers, but works perfectly for the source file. Investigating further, I tried separately narrowing the buffer and making an indirect buffer. The former worked, while the latter failed.

Does this package support indirect buffers?

[dgutov]

Hi!

Sometime in the past we've added support for indirect buffers, and support for narrowed ones. But maybe not the combination of those, yet.

There are still tests for indirect buffers in https://github.com/dgutov/diff-hl/blob/master/test/diff-hl-test.el

But it's possible that they don't cover your usage scenario.

Can you write down how to reproduce your problem step-by-step?

[jamescherti]

Hello @dgutov,

I can confirm that the diff-hl package does not support indirect buffers.

Here is how to reproduce this issue:

1. Open a file that is currently under version control and ensure diff-hl-mode is enabled.
2. Create an indirect buffer for the current file by running M-x clone-indirect-buffer (or C-x 4 c).
3. Modify the text in the base buffer and save. The base buffer's fringe updates correctly, but the indirect buffer's fringe remains empty or stale.
4. Modify the text in the indirect buffer and save. Observe that the base buffer updates its indicators, while the indirect buffer still displays nothing.