Support for boolean cells (#56)

Author: Olivier Chédru

fastexcel-writer/src/main/java/org/dhatim/fastexcel/Cell.java

@@ -52,7 +52,7 @@ void write(Writer w, int r, int c) throws IOException {
                 w.append(" s=\"").append(style).append('\"');
             }
             if (value != null && !(value instanceof Formula)) {
-                w.append(" t=\"").append((value instanceof CachedString) ? 's' : 'n').append('\"');
+                w.append(" t=\"").append((value instanceof CachedString) ? 's' : (value instanceof Boolean ? 'b' : 'n')).append('\"');
             }
             w.append(">");
             if (value instanceof Formula) {
@@ -67,6 +67,8 @@ void write(Writer w, int r, int c) throws IOException {
                     w.append((long) value);
                 } else if (value instanceof Double) {
                     w.append((double) value);
+                } else if (value instanceof Boolean) {
+                    w.append(((Boolean) value).booleanValue() ? '1' : '0');
                 } else {
                     w.append(value.toString());
                 }
@@ -81,16 +83,16 @@ void write(Writer w, int r, int c) throws IOException {
      *
      * @param wb Parent workbook.
      * @param v Cell value. Supported types are
-     * {@link String}, {@link Date}, {@link LocalDate}, {@link LocalDateTime}, {@link ZonedDateTime}
-     * and {@link Number} implementations. Note Excel timestamps do not carry
+     * {@link String}, {@link Date}, {@link LocalDate}, {@link LocalDateTime}, {@link ZonedDateTime},
+     * {@link Number} and {@link Boolean} implementations. Note Excel timestamps do not carry
      * any timezone information; {@link Date} values are converted to an Excel
      * serial number with the system timezone. If you need a specific timezone,
      * prefer passing a {@link ZonedDateTime}.
      */
     void setValue(Workbook wb, Object v) {
         if (v instanceof String) {
             value = wb.cacheString((String) v);
-        } else if (v == null || v instanceof Number) {
+        } else if (v == null || v instanceof Number || v instanceof Boolean) {
             value = v;
         } else if (v instanceof Date) {
             value = TimestampUtil.convertDate((Date) v);

fastexcel-writer/src/main/java/org/dhatim/fastexcel/Worksheet.java

@@ -314,8 +314,8 @@ public void width(int c, double width) {
      * @param r Zero-based row number.
      * @param c Zero-based column number.
      * @param value Cell value. Supported types are
-     * {@link String}, {@link Date}, {@link LocalDate}, {@link LocalDateTime}, {@link ZonedDateTime}
-     * and {@link Number} implementations. Note Excel timestamps do not carry
+     * {@link String}, {@link Date}, {@link LocalDate}, {@link LocalDateTime}, {@link ZonedDateTime},
+     * {@link Number} and {@link Boolean} implementations. Note Excel timestamps do not carry
      * any timezone information; {@link Date} values are converted to an Excel
      * serial number with the system timezone. If you need a specific timezone,
      * prefer passing a {@link ZonedDateTime}.

fastexcel-writer/src/test/java/org/dhatim/fastexcel/Correctness.java

@@ -15,6 +15,19 @@
  */
 package org.dhatim.fastexcel;
 
+import org.apache.commons.io.output.NullOutputStream;
+import org.apache.poi.ss.usermodel.BorderStyle;
+import org.apache.poi.ss.usermodel.DataValidation.ErrorStyle;
+import org.apache.poi.ss.usermodel.DataValidationConstraint;
+import org.apache.poi.ss.usermodel.IndexedColors;
+import org.apache.poi.ss.usermodel.SheetVisibility;
+import org.apache.poi.ss.util.CellRangeAddress;
+import org.apache.poi.xssf.usermodel.XSSFDataValidation;
+import org.apache.poi.xssf.usermodel.XSSFRow;
+import org.apache.poi.xssf.usermodel.XSSFSheet;
+import org.apache.poi.xssf.usermodel.XSSFWorkbook;
+import org.junit.Test;
+
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
@@ -30,23 +43,8 @@
 import java.util.concurrent.ExecutionException;
 import java.util.function.Consumer;
 
-import org.apache.commons.io.output.NullOutputStream;
-import org.apache.poi.ss.usermodel.BorderStyle;
-import org.apache.poi.ss.usermodel.DataValidation.ErrorStyle;
-import org.apache.poi.ss.usermodel.DataValidationConstraint;
-import org.apache.poi.ss.usermodel.IndexedColors;
-import org.apache.poi.ss.usermodel.SheetVisibility;
-import org.apache.poi.ss.util.CellRangeAddress;
-import org.apache.poi.xssf.usermodel.XSSFDataValidation;
-import org.apache.poi.xssf.usermodel.XSSFRow;
-import org.apache.poi.xssf.usermodel.XSSFSheet;
-import org.apache.poi.xssf.usermodel.XSSFWorkbook;
-import org.junit.Test;
-
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.dhatim.fastexcel.SheetProtectionOption.DELETE_ROWS;
-import static org.dhatim.fastexcel.SheetProtectionOption.OBJECTS;
-import static org.dhatim.fastexcel.SheetProtectionOption.SHEET;
+import static org.dhatim.fastexcel.SheetProtectionOption.*;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
@@ -211,6 +209,8 @@ public void singleWorksheet() throws Exception {
             ws.value(i, i++, intValue);
             ws.value(i, i++, longValue);
             ws.value(i, i++, bigDecimalValue);
+            ws.value(i, i++, Boolean.TRUE);
+            ws.value(i, i++, Boolean.FALSE);
             try {
                 ws.finish();
             } catch (IOException ex) {
@@ -240,6 +240,8 @@ public void singleWorksheet() throws Exception {
         assertThat(xws.getRow(i).getCell(i++).getNumericCellValue()).isEqualTo(intValue);
         assertThat(xws.getRow(i).getCell(i++).getNumericCellValue()).isEqualTo(longValue);
         assertThat(new BigDecimal(xws.getRow(i).getCell(i++).getRawValue())).isEqualTo(bigDecimalValue);
+        assertThat(xws.getRow(i).getCell(i++).getBooleanCellValue()).isTrue();
+        assertThat(xws.getRow(i).getCell(i++).getBooleanCellValue()).isFalse();
     }
 
     @Test

pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>org.dhatim</groupId>
         <artifactId>root-oss</artifactId>
-        <version>14.11.0</version>
+        <version>14.11.5</version>
     </parent>
 
     <artifactId>fastexcel-parent</artifactId>