Moving masquerade function and adding test

Author: dhensby

code/Extensions/MasqueradeMemberExtension.php

@@ -22,4 +22,14 @@ public function canMasquerade($member = null)
         return Permission::check('ADMIN', 'any', $member);
     }
 
+    public function masquerade()
+    {
+        // don't use $member->logIn() because it triggers tracking and breaks remember me tokens, etc.
+        $sessionData = Session::get_all();
+        Session::clear_all();
+        Session::set("loggedInAs", $this->getOwner()->ID);
+        Session::set('Masquerade.Old', $sessionData);
+        return $this->getOwner();
+    }
+
 }

code/forms/gridfield/MasqueradeGridFieldDetailForm_ItemRequest.php

@@ -9,15 +9,11 @@ class MasqueradeGridFieldDetailForm_ItemRequest extends GridFieldDetailForm_Item
     public function masquerade()
     {
         $member = $this->getRecord();
-        if (!$member instanceof Member || !$member->canMasquerade()) {
+        if (!$member->hasMethod('canMasquerade') || !$member->hasMethod('masquerade') || !$member->canMasquerade()) {
             Security::permissionFailure($this->getController());
             return;
         }
-        // don't use $member->logIn() because it triggers tracking and breaks remember me tokens, etc.
-        $sessionData = Session::get_all();
-        Session::clear_all();
-        Session::set("loggedInAs", $member->ID);
-        Session::set('Masquerade.Old', $sessionData);
+        $member->masquerade();
         $this->getController()->redirect(Director::absoluteBaseURL());
     }
 

tests/MasqueradeMemberTest.php

@@ -8,7 +8,6 @@ public function testCanMasquerade()
     {
         $this->logInWithPermission('ADMIN');
         $admin = Member::currentUser();
-
         $member = $this->objFromFixture('Member', 'user');
 
         //added function correctly
@@ -39,4 +38,18 @@ public function testCanMasquerade()
         $this->assertFalse($admin->canMasquerade());
     }
 
+    public function testMasquerade()
+    {
+        $this->logInWithPermission('ADMIN');
+        $admin = Member::currentUser();
+        $member = $this->objFromFixture('Member', 'user');
+
+        $this->assertEquals($admin->ID, Session::get('loggedInAs'));
+
+        $member->masquerade();
+
+        $this->assertEquals($member->ID, Session::get('loggedInAs'));
+        $this->assertEquals($admin->ID, Session::get('Masquerade.Old.loggedInAs'));
+    }
+
 }