Use math/rand/v2 in favor of dhrand

As of Go 1.20, math/rand randomly seeds during runtime - https://go.dev/doc/go1.20#mathrandpkgmathrand

math/rand/v2 has a better API - https://go.dev/blog/randv2

Author: dhui

go.mod

@@ -3,7 +3,6 @@ module github.com/dhui/satomic
 require (
 	github.com/DATA-DOG/go-sqlmock v1.4.0
 	github.com/denisenkom/go-mssqldb v0.0.0-20191128021309-1d7a30a10f73
-	github.com/dhui/dhrand v0.1.0
 	github.com/dhui/dktest v0.4.5
 	github.com/go-sql-driver/mysql v1.4.1
 	github.com/jmoiron/sqlx v1.2.0

go.sum

@@ -15,8 +15,6 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/denisenkom/go-mssqldb v0.0.0-20191128021309-1d7a30a10f73 h1:OGNva6WhsKst5OZf7eZOklDztV3hwtTHovdrLHV+MsA=
 github.com/denisenkom/go-mssqldb v0.0.0-20191128021309-1d7a30a10f73/go.mod h1:xbL0rPBG9cCiLr28tMa8zpbdarY27NDyej4t/EjAShU=
-github.com/dhui/dhrand v0.1.0 h1:C8ES1tf4bO37VmLmjdcOR03nYVQDJuF26mMyUITz4NY=
-github.com/dhui/dhrand v0.1.0/go.mod h1:tK3W7Gn/9L6SqpDX5QmS0gX55BjYjUZbJsavMWxj5A0=
 github.com/dhui/dktest v0.4.5 h1:uUfYBIVREmj/Rw6MvgmqNAYzTiKOHJak+enB5Di73MM=
 github.com/dhui/dktest v0.4.5/go.mod h1:tmcyeHDKagvlDrz7gDKq4UAJOLIfVZYkfD5OnHDwcCo=
 github.com/distribution/reference v0.6.0 h1:0IXCQ5g4/QMHHkarYzh5l+u8T3t73zM5QvfrDyIgxBk=
@@ -79,7 +77,6 @@ github.com/sirupsen/logrus v1.9.0 h1:trlNQbNUG3OdDrDil03MCb1H2o9nJ1x4/5LYw7byDE0
 github.com/sirupsen/logrus v1.9.0/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
 github.com/spf13/pflag v1.0.3/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
-github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
 github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
 github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=

savepointers/savepoint_name.go

@@ -2,31 +2,20 @@ package savepointers
 
 import (
 	"encoding/base64"
-	"math/rand"
-)
-
-import (
-	"github.com/dhui/dhrand"
+	"encoding/binary"
+	"math/rand/v2"
 )
 
 // number of bytes used to generate a random savepoint name. 16 bytes is plenty since it's the same size as a uuid
 const savepointNumBytes = 16
 
-var _rand *rand.Rand
-
-func init() {
-	seed, err := dhrand.GenSeed()
-	if err != nil {
-		panic(err)
-	}
-	_rand = rand.New(dhrand.NewLockedSource(seed)) //nolint:gosec
-}
-
 // GenSavepointName quickly generates a unique savepoint name
 func GenSavepointName() string {
 	b := make([]byte, savepointNumBytes)
-	// rand.Read() always returns len(p) and a nil err, so it's save to ignore the error.
-	// https://golang.org/pkg/math/rand/#Rand.Read
-	_rand.Read(b)
+
+	// 2 64-bit ints is 16 bytes
+	binary.NativeEndian.PutUint64(b, rand.Uint64())
+	binary.NativeEndian.PutUint64(b[8:], rand.Uint64())
+
 	return base64.RawStdEncoding.EncodeToString(b)
 }