Allows for '_' in job names

Signed-off-by: joshvanl <[email protected]>

Author: JoshVanL

api.go

@@ -108,7 +108,7 @@ func validateName(name string) error {
 		return errors.New("job name cannot be empty")
 	}
 
-	for _, segment := range strings.Split(strings.ToLower(name), "||") {
+	for _, segment := range strings.Split(strings.ReplaceAll(strings.ToLower(name), "_", "-"), "||") {
 		if errs := validation.IsDNS1123Subdomain(segment); len(errs) > 0 {
 			return fmt.Errorf("job name is invalid %q: %s", name, strings.Join(errs, ", "))
 		}

api_test.go

@@ -480,6 +480,10 @@ func Test_validateName(t *testing.T) {
 			name:   "foo.BAR||foo",
 			expErr: false,
 		},
+		{
+			name:   "foo.BAR_f-oo||foo",
+			expErr: false,
+		},
 	}
 
 	for _, test := range tests {