add counters to garbage collector upon job deletion (#36)

cicoyle · artursouza · commit e4e3cf34dbee · 2024-09-04T15:42:06.000-07:00
Signed-off-by: Cassandra Coyle &lt;cassie@diagrid.io&gt;
diff --git a/api.go b/api.go
@@ -103,6 +103,8 @@ func (c *cron) Delete(ctx context.Context, name string) error {
 	if _, err := c.client.Delete(ctx, jobKey); err != nil {
 		return err
 	}
+	counterKey := c.key.CounterKey(name)
+	c.collector.Push(counterKey)
 
 	if _, ok := c.queueCache.Load(jobKey); !ok {
 		return nil
diff --git a/internal/informer/informer.go b/internal/informer/informer.go
@@ -160,6 +160,7 @@ func (i *Informer) handleEvent(ev *clientv3.Event) (*Event, error) {
 		if i.yard.HasJustDeleted(string(ev.PrevKv.Key)) {
 			return nil, nil
 		}
+		i.collector.Push(i.key.CounterKey(i.key.JobName(ev.Kv.Key)))
 
 		kv = ev.PrevKv
 	default:

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,8 @@ func (c *cron) Delete(ctx context.Context, name string) error {`
`103`	`103`	`if _, err := c.client.Delete(ctx, jobKey); err != nil {`
`104`	`104`	`return err`
`105`	`105`	`}`
	`106`	`+ counterKey := c.key.CounterKey(name)`
	`107`	`+ c.collector.Push(counterKey)`
`106`	`108`
`107`	`109`	`if _, ok := c.queueCache.Load(jobKey); !ok {`
`108`	`110`	`return nil`
Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,7 @@ func (i Informer) handleEvent(ev clientv3.Event) (*Event, error) {`
`160`	`160`	`if i.yard.HasJustDeleted(string(ev.PrevKv.Key)) {`
`161`	`161`	`return nil, nil`
`162`	`162`	`}`
	`163`	`+ i.collector.Push(i.key.CounterKey(i.key.JobName(ev.Kv.Key)))`
`163`	`164`
`164`	`165`	`kv = ev.PrevKv`
`165`	`166`	`default:`