fix crash for url construction when icon is undefined

zhelezkov · zhelezkov · commit 0e6878ae8567 · 2025-02-24T14:36:24.000+02:00
diff --git a/packages/blinks-core/package.json b/packages/blinks-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dialectlabs/blinks-core",
-  "version": "0.20.5",
+  "version": "0.20.6",
   "license": "Apache-2.0",
   "private": false,
   "sideEffects": true,
diff --git a/packages/blinks-core/src/api/BlinkInstance/BlinkInstance.ts b/packages/blinks-core/src/api/BlinkInstance/BlinkInstance.ts
@@ -138,7 +138,11 @@ export class BlinkInstance {
   }
 
   public get icon() {
-    if (this._data.icon.startsWith('data:') || isProxified(this._data.icon)) {
+    if (
+      this._data.icon.startsWith('data:') ||
+      isProxified(this._data.icon) ||
+      !this._data.icon
+    ) {
       return this._data.icon;
     }
     return proxifyImage(this._data.icon).url.toString();

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@dialectlabs/blinks-core",`
`3`		`- "version": "0.20.5",`
	`3`	`+ "version": "0.20.6",`
`4`	`4`	`"license": "Apache-2.0",`
`5`	`5`	`"private": false,`
`6`	`6`	`"sideEffects": true,`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,11 @@ export class BlinkInstance {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`public get icon() {`
`141`		`- if (this._data.icon.startsWith('data:') \|\| isProxified(this._data.icon)) {`
	`141`	`+ if (`
	`142`	`+ this._data.icon.startsWith('data:') \|\|`
	`143`	`+ isProxified(this._data.icon) \|\|`
	`144`	`+ !this._data.icon`
	`145`	`+ ) {`
`142`	`146`	`return this._data.icon;`
`143`	`147`	`}`
`144`	`148`	`return proxifyImage(this._data.icon).url.toString();`