Skip to content

Commit 39fb488

Browse files
Renames/Reorganization (#1231)
* Rename Theme concept to Style * Reorganize/Rename some files * Rename Display nodes to DialogicNodes The class names had already been changed, but the actual files still said "Display". Hopefully this makes them easier to identify. * Fix Merge mistakes * Removing HintLabelSettings in favor of script There is a new script that can be added to Labels to setup a similar style. Hopefully this won't lead to such annoying changes all the time. * Fix GeneralSettings Co-authored-by: Emi <[email protected]>
1 parent d3626a3 commit 39fb488

File tree

61 files changed

+2153
-2161
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+2153
-2161
lines changed

addons/dialogic/Editor/CharacterEditor/CharacterEditor.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ func update_preview() -> void:
283283

284284
var scene = null
285285
if current_portrait_data.get('scene', '').is_empty():
286-
scene = load("res://addons/dialogic/Other/DefaultPortrait.tscn")
286+
scene = load("res://addons/dialogic/Events/Character/DefaultPortrait.tscn")
287287
else:
288288
scene = load(current_portrait_data.get('scene'))
289289

File renamed without changes.

addons/dialogic/Editor/Common/HintLabelSettings.tres

Lines changed: 0 additions & 1414 deletions
This file was deleted.

addons/dialogic/Other/TestTimelineScene.gd renamed to addons/dialogic/Editor/Common/TestTimelineScene.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ extends Control
33
func _ready() -> void:
44
$PauseIndictator.hide()
55
var dialog_scene_path :String= DialogicUtil.get_project_setting(
6-
'dialogic/editor/test_dialog_scene', 'res://addons/dialogic/Example Assets/ExampleScenes/DefaultDialogNode.tscn')
6+
'dialogic/editor/test_dialog_scene', "res://addons/dialogic/Example Assets/example-scenes/DialogicDefaultScene.tscn")
77
var scene = load(dialog_scene_path).instantiate()
88
add_child(scene)
99
if scene is CanvasLayer:

addons/dialogic/Other/TestTimelineScene.tscn renamed to addons/dialogic/Editor/Common/TestTimelineScene.tscn

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
[gd_scene load_steps=2 format=3 uid="uid://c01ibbjc4ijvh"]
1+
[gd_scene load_steps=2 format=3]
22

3-
[ext_resource type="Script" path="res://addons/dialogic/Other/TestTimelineScene.gd" id="1"]
3+
[ext_resource type="Script" path="res://addons/dialogic/Editor/Common/TestTimelineScene.gd" id="1"]
44

55
[node name="TestTimelineScene" type="Control"]
66
anchor_right = 1.0

addons/dialogic/Editor/EditorView.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ func _on_play_timeline():
249249
ProjectSettings.set_setting('dialogic/editor/current_timeline_path', _get_timeline_editor().current_timeline.resource_path)
250250
ProjectSettings.save()
251251

252-
DialogicUtil.get_dialogic_plugin().editor_interface.play_custom_scene("res://addons/dialogic/Other/TestTimelineScene.tscn")
252+
DialogicUtil.get_dialogic_plugin().editor_interface.play_custom_scene("res://addons/dialogic/Editor/Common/TestTimelineScene.tscn")
253253

254254

255255
#########################################################
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
@tool
2+
extends Label
3+
4+
# Called when the node enters the scene tree for the first time.
5+
func _ready():
6+
label_settings = LabelSettings.new()
7+
label_settings.font = get_theme_font("doc_italic", "EditorFonts")
8+
label_settings.font_size = get_theme_font_size('font_size', 'Label')
9+
label_settings.font_color = get_theme_color("accent_color", "Editor")

addons/dialogic/Editor/Settings/SettingsEditor.gd

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@
22
extends PanelContainer
33

44
func _ready():
5-
var info_font_settings :LabelSettings = load("res://addons/dialogic/Editor/Common/HintLabelSettings.tres")
6-
info_font_settings.font = get_theme_font("doc_italic", "EditorFonts")
7-
info_font_settings.font_size = get_theme_font_size('font_size', 'Label')
8-
info_font_settings.font_color = get_theme_color("accent_color", "Editor")
9-
105
hide()
116
visibility_changed.connect(_on_visibility_changed)
127

addons/dialogic/Editor/Settings/Settings_General.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func refresh():
2323
%CustomEventsFolderLabel.text = DialogicUtil.get_project_setting('dialogic/custom_events_folder', 'res://addons/dialogic_additions/Events')
2424
%CustomEventsFolderButton.icon = get_theme_icon("Folder", "EditorIcons")
2525
%TestingSceneButton.icon = get_theme_icon("Folder", "EditorIcons")
26-
%TestingSceneLabel.text = DialogicUtil.get_project_setting('dialogic/editor/test_dialog_scene', 'res://addons/dialogic/Other/DefaultDialogNode.tscn')
26+
%TestingSceneLabel.text = DialogicUtil.get_project_setting('dialogic/editor/test_dialog_scene', "res://addons/dialogic/Example Assets/example-scenes/DialogicDefaultScene.tscn")
2727
%PhysicsTimerButton.button_pressed = DialogicUtil.is_physics_timer()
2828

2929
# Color Palett

addons/dialogic/Editor/Settings/Settings_General.tscn

Lines changed: 17 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
[gd_scene load_steps=8 format=3 uid="uid://dm4kxvcn7d7ug"]
22

33
[ext_resource type="Script" path="res://addons/dialogic/Editor/Settings/Settings_General.gd" id="2"]
4-
[ext_resource type="LabelSettings" uid="uid://bqlmi2bwcj0s6" path="res://addons/dialogic/Editor/Common/HintLabelSettings.tres" id="2_hs15a"]
54
[ext_resource type="StyleBox" uid="uid://dmsjhgv22dns8" path="res://addons/dialogic/Editor/Common/TitleBgStylebox.tres" id="2_u584y"]
5+
[ext_resource type="Script" path="res://addons/dialogic/Editor/Settings/HintLabelStylingScript.gd" id="2_uxx4f"]
66

7-
[sub_resource type="StyleBoxFlat" id="StyleBoxFlat_6mpk2"]
7+
[sub_resource type="StyleBoxFlat" id="StyleBoxFlat_ui276"]
88
content_margin_left = 5.0
99
content_margin_top = 5.0
1010
content_margin_right = 5.0
1111
content_margin_bottom = 5.0
1212
bg_color = Color(0.545098, 0.545098, 0.545098, 0.211765)
1313

14-
[sub_resource type="Image" id="Image_iyfpw"]
14+
[sub_resource type="Image" id="Image_6ds5e"]
1515
data = {
1616
"data": PackedByteArray(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0),
1717
"format": "LumAlpha8",
@@ -21,7 +21,7 @@ data = {
2121
}
2222

2323
[sub_resource type="ImageTexture" id="7"]
24-
image = SubResource("Image_iyfpw")
24+
image = SubResource("Image_6ds5e")
2525

2626
[sub_resource type="StyleBoxFlat" id="StyleBoxFlat_3mwvq"]
2727
content_margin_left = 5.0
@@ -48,7 +48,7 @@ size_flags_horizontal = 3
4848
layout_mode = 2
4949
offset_right = 958.0
5050
offset_bottom = 36.0
51-
theme_override_styles/normal = SubResource("StyleBoxFlat_6mpk2")
51+
theme_override_styles/normal = SubResource("StyleBoxFlat_ui276")
5252
text = "Extensions"
5353

5454
[node name="HBoxContainer" type="HBoxContainer" parent="General"]
@@ -89,27 +89,21 @@ offset_top = 70.0
8989
offset_right = 958.0
9090
offset_bottom = 96.0
9191
text = "You should restart godot after changing this path!"
92-
label_settings = ExtResource("2_hs15a")
93-
94-
[node name="HSeparator" type="HSeparator" parent="General"]
95-
layout_mode = 2
96-
offset_top = 100.0
97-
offset_right = 958.0
98-
offset_bottom = 104.0
92+
script = ExtResource("2_uxx4f")
9993

10094
[node name="TitleLabel2" type="Label" parent="General"]
10195
layout_mode = 2
102-
offset_top = 108.0
96+
offset_top = 100.0
10397
offset_right = 958.0
104-
offset_bottom = 144.0
105-
theme_override_styles/normal = SubResource("StyleBoxFlat_6mpk2")
98+
offset_bottom = 136.0
99+
theme_override_styles/normal = SubResource("StyleBoxFlat_ui276")
106100
text = "Testing"
107101

108102
[node name="HBoxContainer2" type="HBoxContainer" parent="General"]
109103
layout_mode = 2
110-
offset_top = 148.0
104+
offset_top = 140.0
111105
offset_right = 958.0
112-
offset_bottom = 174.0
106+
offset_bottom = 166.0
113107

114108
[node name="Label" type="Label" parent="General/HBoxContainer2"]
115109
layout_mode = 2
@@ -139,23 +133,23 @@ icon = SubResource("7")
139133

140134
[node name="HSeparator2" type="HSeparator" parent="General"]
141135
layout_mode = 2
142-
offset_top = 178.0
136+
offset_top = 170.0
143137
offset_right = 958.0
144-
offset_bottom = 182.0
138+
offset_bottom = 174.0
145139

146140
[node name="TitleLabel3" type="Label" parent="General"]
147141
layout_mode = 2
148-
offset_top = 186.0
142+
offset_top = 178.0
149143
offset_right = 958.0
150-
offset_bottom = 222.0
144+
offset_bottom = 214.0
151145
theme_override_styles/normal = SubResource("StyleBoxFlat_3mwvq")
152146
text = "Timer"
153147

154148
[node name="HBoxContainer3" type="HBoxContainer" parent="General"]
155149
layout_mode = 2
156-
offset_top = 226.0
150+
offset_top = 218.0
157151
offset_right = 958.0
158-
offset_bottom = 252.0
152+
offset_bottom = 244.0
159153

160154
[node name="Label" type="Label" parent="General/HBoxContainer3"]
161155
layout_mode = 2

0 commit comments

Comments
 (0)