Multiple small improvements & Autocompletion for text editor (#1355)

* Variable Editor improvements

- spaces in names are replaced with underscores
- on focus, the whole name/value is selected
- you can enter a name field with ENTER now (previoulsy double-click only)

* Warning for empty and duplicate glossary items

* Fixing next indicator

* Allow adding buttons to events

- Adds _event_node reference to event resource. This way you can access the visual editor node from the event, (while in that mode!)
- Adds button functionality to EventNode scene as well as add_header_button() method to event resource
- Adds functionality to open a specific settings tab by passing it's name as extra_infromation parameter.
- Adds a button to the set variable event, that opens the variable editor

* Add Button to edit character (on character event)

* Fix Condition name and End ui (buttons)

* Fix Variables Subsystem name to VAR again (broke set variable event)

* Small style fixes (&& ||)

* Improve Leave All UI & add "edit character" button (character event)

* Allow use of array for icon in event.add_header_button()

Usefull for editor icons. (loaded with callv('get_theme_icon')`

* Move test_timeline_scene and improve pausing

* Add text editor auto-completion

# Auto-completion for text editor
Adds autocompletion to the text editor.
The following things are suggested:
- shortcode identifiers
- shortcode parameters
- if shortcode parameter has a suggesions function setup, those will be suggested as values
- Character names
- Character Portraits
- Text Effects
- Join, Leave, Update, VAR, if, elif, else
- Variable Names

## Paramter Value suggestions
For many events some value suggestions have been added:
- true and false for boolean values
- audio bus's for bus
- timelines for jump event
- enum values for History and Position event
# Other Changes
- Variable Dict to Array method moved to DialogicUtil

Author: Jowan-Spooner

addons/dialogic/Editor/Events/EventNode/EventNode.gd

@@ -239,7 +239,17 @@ func build_editor():
 			editor_node = Label.new()
 			editor_node.text = p.display_info.text
 			editor_node.vertical_alignment = VERTICAL_ALIGNMENT_CENTER
-		
+		elif p.dialogic_type == resource.ValueType.Button:
+			editor_node = Button.new()
+			editor_node.text = p.display_info.text
+			if typeof(p.display_info.icon) == TYPE_ARRAY:
+				editor_node.icon = callv('get_theme_icon', p.display_info.icon)
+			else:
+				editor_node.icon = p.display_info.icon
+			editor_node.flat = true
+			editor_node.custom_minimum_size.x = 30*DialogicUtil.get_editor_scale()
+			editor_node.tooltip_text = p.display_info.tooltip
+			editor_node.pressed.connect(p.display_info.callable)
 		## CUSTOM
 		elif p.dialogic_type == resource.ValueType.Custom:
 			if p.display_info.has('path'):

addons/dialogic/Editor/Events/Fields/ComplexPicker.gd

@@ -44,7 +44,7 @@ func set_right_text(value:String) -> void:
 func set_value(value, text : String = '') -> void:
 	if value == null:
 		%Search.text = empty_text
-	elif file_extension != "" && file_extension != ".dch" && file_extension != ".dtl":
+	elif file_extension != "" and file_extension != ".dch" and file_extension != ".dtl":
 		%Search.text = value.resource_path
 		%Search.tooltip_text = value.resource_path
 	elif value:
@@ -119,7 +119,7 @@ func _on_Search_text_changed(new_text:String, just_update:bool = false) -> void:
 	if new_text == "" and !just_update:
 		changed_to_empty()
 
-	var suggestions = get_suggestions_func.call(new_text)
+	var suggestions :Dictionary = get_suggestions_func.call(new_text)
 
 	var line_length:int = 0
 	var idx:int = 0
@@ -176,7 +176,7 @@ func suggestion_selected(index : int, position:=Vector2(), button_index:=MOUSE_B
 		current_value = null
 
 	# if this is a resource, then load it instead of assigning the string:
-	elif file_extension != "" && file_extension != ".dch" && file_extension != ".dtl":
+	elif file_extension != "" and file_extension != ".dch" and file_extension != ".dtl":
 		var file = load(%Suggestions.get_item_metadata(index))
 		current_value = file
 	else:

addons/dialogic/Editor/Events/Fields/ConditionPicker.gd

@@ -114,24 +114,16 @@ func get_value1_suggestions(filter:String) -> Dictionary:
 	if filter:
 		suggestions[filter] = {'value':filter, 'editor_icon':["GuiScrollArrowRight", "EditorIcons"]}
 	var vars = DialogicUtil.get_project_setting('dialogic/variables', {})
-	for var_path in list_variables(vars):
+	for var_path in DialogicUtil.list_variables(vars):
 		suggestions[var_path] = {'value':'{'+var_path+"}", 'editor_icon':["ClassList", "EditorIcons"]}
 	return suggestions
 
-func list_variables(dict, path = "") -> Array:
-	var array = []
-	for key in dict.keys():
-		if typeof(dict[key]) == TYPE_DICTIONARY:
-			array.append_array(list_variables(dict[key], path+key+"."))
-		else:
-			array.append(path+key)
-	return array
 
 func get_value2_suggestions(filter:String) -> Dictionary:
 	var suggestions = {}
 	if filter:
 		suggestions[filter] = {'value':filter, 'editor_icon':["GuiScrollArrowRight", "EditorIcons"]}
 	var vars = DialogicUtil.get_project_setting('dialogic/variables', {})
-	for var_path in list_variables(vars):
+	for var_path in DialogicUtil.list_variables(vars):
 		suggestions[var_path] = {'value':'{'+var_path+"}", 'editor_icon':["ClassList", "EditorIcons"]}
 	return suggestions

addons/dialogic/Editor/Settings/SettingsEditor.gd

@@ -15,6 +15,8 @@ func _ready():
 
 func _open(extra_information:Variant = null) -> void:
 	refresh()
+	if typeof(extra_information) == TYPE_STRING and has_node('Tabs/'+extra_information):
+		$Tabs.current_tab = get_node('Tabs/'+extra_information).get_index()
 
 
 func _close():

addons/dialogic/Editor/TimelineEditor/TextEditor/syntax_highlighter.gd

@@ -57,10 +57,10 @@ func _init():
 	character_name_color = editor_settings.get('text_editor/theme/highlighting/executing_line_color')
 	character_portrait_color = character_name_color.lightened(0.6)
 
-	shortcode_regex.compile("\\W*\\[(?<id>\\w*)(?<args>[^\\]]*)?\\]")
+	shortcode_regex.compile("\\W*\\[(?<id>\\w*)(?<args>[^\\]]*)?")
 	shortcode_param_regex.compile('((?<parameter>[^\\s=]*)\\s*=\\s*"(?<value>([^=]|\\\\=)*)(?<!\\\\)")')
 	text_event_regex.compile("\\W*((\")?(?<name>(?(2)[^\"\\n]*|[^(: \\n]*))(?(2)\"|)(\\W*\\((?<portrait>.*)\\))?\\s*(?<!\\\\):)?(?<text>.*)")
-	text_effects_regex.compile("(?<!\\\\)\\[\\s*(?<command>mood|portrait|speed|signal|pause)\\s*(=\\s*(?<value>.+?)\\s*)?\\]")
+	text_effects_regex.compile("(?<!\\\\)\\[\\s*(?<command>mood|portrait|speed|signal|pause|br)\\s*(=\\s*(?<value>.+?)\\s*)?\\]")
 	character_event_regex.compile("(?<type>Join|Update|Leave)\\s*(\")?(?<name>(?(2)[^\"\\n]*|[^(: \\n]*))(?(2)\"|)(\\W*\\((?<portrait>.*)\\))?(\\s*(?<position>\\d))?(\\s*\\[(?<shortcode>.*)\\])?")
 
 func _get_line_syntax_highlighting(line:int) -> Dictionary: