Skip to content

Commit b4706ee

Browse files
KvaGramKvaGramJowan-Spooner
authored
Fix typoes in voice (#1213)
* Add start and stop logic to CharacterVoice.gd also fixed a naming error in dialog_node * Add some lines of code I forgot to save before committing it happens. And it is always a shame when it does. * implement start_time and stop_time in audiopicker The changes to the preview feature works as expected * Add collapsable secund row to audiopicker Known issue: conflicts with EventPart_VoiceEditor.gd The labels column does not change size to match the resizable audiopicker * Merge Label and Voices containers into a grid container This has solved the issue from the previus commit. This is however a hacky fix, and may have unforseen consequences. * Change the collapse icons * First UI test * Second UI improvments For now the Audio-Region section will be disabled for Audio Event and Background Music event. * Just added a tooltip * New AudioPicker layout/design Was trying to make it clearer what belongs together. Hope it works. * Fix embarresing typo I had a feeling something were wrong, now I fixed it. * Updated Changelog Apparently there wasn't even a note about the Voice Line System... ;-/ * In in a nw=v feature With this, the text event will skip to the next, the moment the voiceacting is complete. It is a hack, and needs to be better refined to fit in base code, but it works. Tests work as expected. When tested on a line without voice, it defaults to a 0 secund skip * fix typoes in voice Co-authored-by: KvaGram <0kvakk@gmailcom> Co-authored-by: Jowan-Spooner <[email protected]>
1 parent a19d2c8 commit b4706ee

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

addons/dialogic/Events/Text/event.gd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ func _execute() -> void:
7474
dialogic.Text.show_next_indicators(false, true)
7575
var wait:float = DialogicUtil.get_project_setting('dialogic/text/autocontinue_delay', 1)
7676
# if voiced, grab remaining time left on the voiceed line's audio region - KvaGram
77-
if dialogic.has_subsystem('Voice') and dialogic.Voice.is_Voiced(dialogic.current_event_idx):
77+
if dialogic.has_subsystem('Voice') and dialogic.Voice.is_voiced(dialogic.current_event_idx):
7878
#autocontinue settings is set as minimal. change or keep this? - Kvagram
79-
wait = max(wait, dialogic.Voice.getRemainingTime())
79+
wait = max(wait, dialogic.Voice.get_remaining_time())
8080
await dialogic.get_tree().create_timer(wait).timeout
8181
dialogic.handle_next_event()
8282
else:

0 commit comments

Comments
 (0)