feat: add password validation for joining duels (#171)

* chore: translate server error messages to English

* feat: add password validation for joining duels

Author: diegofcornejo

src/edopro/room/application/JoinHandler.ts

@@ -35,7 +35,7 @@ export class JoinHandler implements JoinMessageHandler {
 
 		if (!room) {
 			this.socket.send(
-				ServerErrorClientMessage.create("Sala no encontrada. Intenta recargando la lista")
+				ServerErrorClientMessage.create("Room not found. Try reloading the list")
 			);
 
 			this.socket.send(ErrorClientMessage.create(ErrorMessages.JOIN_ERROR));
@@ -46,7 +46,7 @@ export class JoinHandler implements JoinMessageHandler {
 		}
 
 		if (room.password !== joinMessage.password) {
-			this.socket.send(ServerErrorClientMessage.create("Clave incorrecta"));
+			this.socket.send(ServerErrorClientMessage.create("Wrong password"));
 			this.socket.send(ErrorClientMessage.create(ErrorMessages.JOIN_ERROR));
 			this.socket.destroy();
 

src/edopro/room/domain/RoomState.ts

@@ -88,7 +88,7 @@ export abstract class RoomState {
 	): void {
 		socket.send(
 			ServerErrorClientMessage.create(
-				`Ya existe un jugador con el nombre :${playerInfoMessage.name}`
+				`Already exists a player with the name :${playerInfoMessage.name}`
 			)
 		);
 		socket.send(ErrorClientMessage.create(ErrorMessages.JOIN_ERROR));

src/edopro/room/domain/states/dueling/DuelingState.ts

@@ -654,6 +654,12 @@ export class DuelingState extends RoomState {
 		this.logger.debug("DUELING: JOIN");
 		const playerInfoMessage = new PlayerInfoMessage(message.previousMessage, message.data.length);
 		const joinMessage = new JoinGameMessage(message.data);
+		if (room.password !== joinMessage.password) {
+			socket.send(ServerErrorClientMessage.create("Wrong password"));
+			socket.send(ErrorClientMessage.create(ErrorMessages.JOIN_ERROR));
+			socket.destroy();
+			return;
+		}
 		const reconnectingPlayer = this.playerAlreadyInRoom(playerInfoMessage, room, socket);
 
 		if (!(reconnectingPlayer instanceof Client)) {

src/edopro/room/domain/states/waiting/WaitingState.ts

@@ -104,15 +104,15 @@ export class WaitingState extends RoomState {
 		room.clients.forEach((_client: Client) => {
 			_client.sendMessage(
 				ServerErrorClientMessage.create(
-					`El Jugador:${playerSelect.name} ha sido Baneado de esta Sala, solo podra ingresar como espectador!!`
+					`The player:${playerSelect.name} has been banned from this room, he can only enter as a spectator!!`
 				)
 			);
 		});
 
 		room.spectators.forEach((_client: Client) => {
 			_client.sendMessage(
 				ServerErrorClientMessage.create(
-					`El Jugador:${playerSelect.name} ha sido Baneado de esta Sala, solo podra ingresar como espectador!!`
+					`The player:${playerSelect.name} has been banned from this room, he can only enter as a spectator!!`
 				)
 			);
 		});