centralize version info in package.json for easier updating

Author: dibenede

BUILD.bazel

@@ -6,6 +6,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_attributes", "pkg_files", "strip_prefix")
 load("@rules_pkg//:pkg.bzl", "pkg_tar", "pkg_zip")
 load("//:protobuf_javascript_release.bzl", "package_naming")
 
+exports_files(["generate-version-header.js", "package.json"])
+
 config_setting(
     name = "x64_x86_windows",
     values = {"cpu": "x64_x86_windows"},

download-protoc-gen-js.js

@@ -3,7 +3,7 @@ const os = require('os');
 const path = require('path');
 const AdmZip = require('adm-zip');
 
-const VERSION = '4.0.0';
+const VERSION = require('./package.json').version;
 const BIN_DIR = path.join(__dirname, 'bin');
 
 function getPlatform() {

generate-version-header.js

@@ -0,0 +1,14 @@
+const fs = require('fs');
+const path = require('path');
+
+const version = require('./package.json').version;
+const headerContent = `// Generated by generate-version-header.js
+#ifndef PROTOBUF_JAVASCRIPT_VERSION_H__
+#define PROTOBUF_JAVASCRIPT_VERSION_H__
+
+const char* const kProtobufJavascriptVersion = "${version}";
+
+#endif  // PROTOBUF_JAVASCRIPT_VERSION_H__
+`;
+
+fs.writeFileSync(process.argv[2], headerContent);

generator/BUILD.bazel

@@ -1,3 +1,11 @@
+genrule(
+    name = "generate_version_header",
+    srcs = ["//:package.json"],
+    outs = ["version.h"],
+    cmd = "node $(location //:generate-version-header.js) $(OUTS)",
+    tools = ["//:generate-version-header.js"],
+)
+
 cc_binary(
     name = "protoc-gen-js",
     srcs = [
@@ -6,6 +14,7 @@ cc_binary(
         "protoc-gen-js.cc",
         "well_known_types_embed.cc",
         "well_known_types_embed.h",
+        ":version.h",
     ],
     visibility = ["//visibility:public"],
     deps = [

generator/protoc-gen-js.cc

@@ -25,21 +25,20 @@
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT of THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include <google/protobuf/compiler/plugin.h>
 #include <iostream>
 #include <string>
 
 #include "generator/js_generator.h"
-
-const char* kVersion = "4.0.0";
+#include "generator/version.h"
 
 int main(int argc, char** argv) {
   for (int i = 1; i < argc; ++i) {
     if (std::string(argv[i]) == "--version") {
-      std::cout << "protoc-gen-js version " << kVersion << std::endl;
+      std::cout << "protoc-gen-js version " << kProtobufJavascriptVersion << std::endl;
       return 0;
     }
   }

package.json

@@ -21,6 +21,7 @@
     "jasmine": "~3.5.0"
   },
   "scripts": {
+    "prebuild": "node update-bazel-versions.js",
     "build": "node ./node_modules/gulp/bin/gulp.js dist",
     "test": "node ./node_modules/gulp/bin/gulp.js test",
     "clean": "node ./node_modules/gulp/bin/gulp.js clean",

update-bazel-versions.js

@@ -0,0 +1,16 @@
+const fs = require('fs');
+const path = require('path');
+
+const version = require('./package.json').version;
+
+// Update MODULE.bazel
+const moduleBazelPath = path.join(__dirname, 'MODULE.bazel');
+let moduleBazelContent = fs.readFileSync(moduleBazelPath, 'utf8');
+moduleBazelContent = moduleBazelContent.replace(/version = ".*"/, `version = "${version}"`);
+fs.writeFileSync(moduleBazelPath, moduleBazelContent);
+
+// Update protobuf_javascript_release.bzl
+const releaseBzlPath = path.join(__dirname, 'protobuf_javascript_release.bzl');
+let releaseBzlContent = fs.readFileSync(releaseBzlPath, 'utf8');
+releaseBzlContent = releaseBzlContent.replace(/_PROTOBUF_JAVASCRIPT_VERSION = ".*"/, `_PROTOBUF_JAVASCRIPT_VERSION = "${version}"`);
+fs.writeFileSync(releaseBzlPath, releaseBzlContent);